-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #45, Opaque CFE_SB_MsgId_t values #46
Fix #45, Opaque CFE_SB_MsgId_t values #46
Conversation
Note - the robo-formatter apparently insists that we shouldn't put one argument per line, even though this is much more readable that way:
Does the CCB really think that the robo-formatter is better here? In this case (and one other) I had intentionally put one argument per line because it is more readable. |
f2c3ac2
to
dae1451
Compare
Pushed simplified changeset that corresponds with other apps - see description here: nasa/sample_app#54 (comment) |
Related to nasa/cFE#592 |
CCB 20200408 - Split up into parts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking based on CCB 20200408
dae1451
to
7e36208
Compare
Update to minimal change to correlate with CFE. Required to resolve compile error when building RTEMS with extended headers. |
Do not assume CFE_SB_MsgId_t is implicitly integral in nature. When an integer value is required for printing or backward compatibility, use the explicit conversion routine to get this.
7e36208
to
1eacca0
Compare
CCB 20200506 - APPROVED |
Describe the contribution
Apply the
CFE_SB_MsgIdToValue()
andCFE_SB_ValueToMsgId()
routines where compatibility with an integer MsgId is necessary - syslog prints, events, compile-time MID#define
values.Fixes #45
Testing performed
Unit test
Execute CFE and sanity-check normal operation - send commands to app using
cmdUtil
and confirm commands are processed normally.Expected behavior changes
No impact to behavior.
System(s) tested on
Ubuntu 18.04 LTS, 64-bit
Additional context
In future versions of CFE SB the MsgId type might not be a simple integer, so this is one step in the direction of avoiding this assumption in apps.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.