Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci_lab Integration candidate: 2021-03-30 #85

Merged
merged 4 commits into from
Apr 1, 2021
Merged

Conversation

astrogeco
Copy link
Contributor

@astrogeco astrogeco commented Mar 31, 2021

Describe the contribution

Fix #82, remove app registration
Fix #73, use zero copy API

Testing performed

ci_lab checks https://github.com/nasa/ci_lab/pull/85/checks
bundle checks https://github.com/nasa/cFS/pull/227/checks

Expected behavior changes

PR #83

Removes unnecessary call to CFE_ES_RegisterApp() since app registration is done automatically.

PR #84

Demonstrates the use of the Zero Copy API. Adds a step that obtains a buffer prior to calling OS_SocketRecvFrom then transmits that same buffer directly rather than copying it.

Additional context

Part of nasa/cFS#227

Third party code

None

Authors

@jphickey

jphickey and others added 4 commits March 23, 2021 11:00
It is not necessary for applications to register themselves, this is
all done automatically.
Updates CI_LAB to obtain a buffer prior to calling OS_SocketRecvFrom,
and then transmit that same buffer directly rather than copying it.

This demonstrates use of the Zero Copy API.
@astrogeco astrogeco marked this pull request as ready for review April 1, 2021 23:02
@astrogeco astrogeco merged commit 4b65271 into main Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove references to CFE_ES_RegisterApp Refactor ingest to utilize zero copy (can reduce two copy to one)
2 participants