Skip to content

Commit

Permalink
GQL-95: Updates Node to version 22 (#150)
Browse files Browse the repository at this point in the history
* GQL-95: Running npm audit fix

* GQL-95: Newline on nvmrc

* GQL-95: Editing maintainers list to support address

* GQL-95: Update test ci test rules to make it easier to update node next time around
  • Loading branch information
eudoroolivares2016 authored Dec 5, 2024
1 parent 2e4c494 commit 5db75e7
Show file tree
Hide file tree
Showing 8 changed files with 24 additions and 28 deletions.
12 changes: 9 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: ['lts/hydrogen']
node-version: ['lts/jod']
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand Down Expand Up @@ -40,7 +40,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: ['lts/hydrogen']
node-version: ['lts/jod']
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand Down Expand Up @@ -69,6 +69,12 @@ jobs:
uses: codecov/codecov-action@v4
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
tests-passed:
needs: ['jest', 'python-test']
runs-on: ubuntu-latest
steps:
- name: All Tests Have Passed
run: 'echo true'

python-test:
runs-on: ubuntu-latest
Expand All @@ -90,7 +96,7 @@ jobs:
working-directory: ./src/earthdataVarinfo
deploy:
if: success() && github.ref == 'refs/heads/main' # only run on main success
needs: [jest, python-test] # only run after jest and python-test jobs complete
needs: [tests-passed] # only run after all test jobs complete
runs-on: ubuntu-latest
steps:
- name: Checkout code
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
lts/hydrogen
lts/jod
2 changes: 1 addition & 1 deletion babel.config.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
[
"@babel/preset-env", {
"targets": {
"node": "18",
"node": "22",
"esmodules": true
}
}
Expand Down
2 changes: 1 addition & 1 deletion bin/deploy-bamboo.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ node_modules
EOF

cat <<EOF > Dockerfile
FROM node:18.16-bullseye
FROM node:22
COPY . /build
WORKDIR /build
RUN npm ci --omit=dev
Expand Down
14 changes: 8 additions & 6 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 2 additions & 14 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,8 @@
},
"maintainers": [
{
"name": "Ryan Abbott",
"email": "ryan@element84.com"
},
{
"name": "Matthew Crouch",
"email": "matthew@element84.com"
},
{
"name": "Trevor Lang",
"email": "trevor@element84.com"
},
{
"name": "Mark Schmele",
"email": "mark.h.schmele@nasa.gov"
"name": "Earthdata Search",
"email": "support@earthdata.nasa.gov"
}
],
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion serverless-infrastructure.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ service: graphql-infrastructure

provider:
name: aws
runtime: nodejs18.x
runtime: nodejs22.x
region: us-east-1
stage: ${opt:stage, 'dev'}
vpc:
Expand Down
2 changes: 1 addition & 1 deletion serverless.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ service: graphql

provider:
name: aws
runtime: nodejs18.x
runtime: nodejs22.x
region: us-east-1
stage: ${opt:stage, 'development'}
endpointType: PRIVATE
Expand Down

0 comments on commit 5db75e7

Please sign in to comment.