-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GQL-87: Bug: Surface cmr errors for user readability #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macrouch
requested changes
Oct 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 106 106
Lines 2400 2410 +10
Branches 269 273 +4
=========================================
+ Hits 2400 2410 +10 ☔ View full report in Codecov by Sentry. |
macrouch
reviewed
Oct 30, 2024
macrouch
approved these changes
Oct 30, 2024
cgokey
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature?
When a user tries to Save & Publish, occationaly an error will come back from CMR. Previously, every cmr error would return the same error message: 'An unknown error occurred. Please refer to the ID ${requestId} when contacting Earthdata Operations (support@earthdata.nasa.gov).' This ticket surfaces both the location of the error and the error message itself. It also preserves how error messages were handled previously.
What is the Solution?
Two things:
What areas of the application does this impact?
index.js under permissions
parseError.js
Testing
Reproduction steps
Attachments
GraphQL:
MMT:
Checklist