Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMR-9489: Bumping the UMM-S record to add "Aggregation" field #70

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

eudoroolivares2016
Copy link
Contributor

@eudoroolivares2016 eudoroolivares2016 commented Oct 10, 2023

…on field"

Overview

What is the feature?

We need to add the "Aggregation" for the service concept into cmr-graphql This field is contained on the service v1.5.2 (https://git.earthdata.nasa.gov/projects/EMFD/repos/unified-metadata-model/browse/service/v1.5.2)

"Aggregation is JSON field" which is a child of the serviceOptions field.

What is the Solution?

Update the UMM-S version being queried from CMR to v1.5.2

What areas of the application does this impact?

UMM-S/service queries

Testing

Reproduction steps

Query for a services which contains the aggregation field such as S1200463978-CMR_ONLY in the SIT env

Attachments

N/A

Checklist

  • [n/a] I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • [n/a] I have commented my code, particularly in hard-to-understand areas
  • [n/a] I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #70 (bd8d492) into main (b7e6d97) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #70   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           61        61           
  Lines         1292      1292           
  Branches       176       176           
=========================================
  Hits          1292      1292           

@eudoroolivares2016 eudoroolivares2016 changed the title CMR-9489: Bumping the UMM-S record to add "Aggregation field" CMR-9489: Bumping the UMM-S record to add "Aggregation" field Oct 10, 2023
@macrouch macrouch merged commit 965460b into main Oct 10, 2023
5 checks passed
@macrouch macrouch deleted the CMR-9489 branch October 10, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants