-
Notifications
You must be signed in to change notification settings - Fork 8
Refactor and clean up GROWTH tiling schemes #9
Conversation
@mcoughlin, I would like to unify the options for all three tiling methods (the geodesic tiling and the two spiral tilings). The geodesic tiling has one natural argument: the desired number of tiles. The reason that this is the natural argument is that it allows only certain integer values, and it must solve for the actual number of tiles given the requested minimum number of tiles. The other two tilings take two arguments (fov, scale), but both of those arguments really control the average areal density of the tiles. What would be the most natural argument(s) for all three tilings to take? |
63de5c9
to
96c7bf6
Compare
@lpsinger The "scale" term is redundant and a holdover from using the FOV in the config files. I do think something equivalent to "spacing between tiles" is what we are after in the end. |
OK, then how about number of tiles, so that it's dimensionless? |
My only concern is that people may not intuitively know how to calculate the number of tiles for a given FOV. Do we provide them some guidance maybe? |
So maybe area per tile is better? |
yes that sounds good to me. |
The |
I misspoke. The |
Yes this is more accurate. |
- Move functions to the dorado.scheduling.tesselation module. - Clean up existing GROWTH methods. - Update all methods to take a single resolution parameter, area. - Convert docstrings to Numpydoc format. - Add example code. - Add to Sphinx project documentation. - Use Astropy quantities for angle arguments. - Write output in ECSV format. - Remove logger.
96c7bf6
to
2a8a19b
Compare
@mcoughlin, I've updated all of the methods to take an area parameter. Please review both the golden angle spiral and the sinusoidal grid methods. I have reimplemented them to make the code more transparent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really love this Leo. Will be great for the users.
Great! FYI I made some small changes to the indexing in the sinusoidal routine, to improve handling of the boundaries in ra and dec. |
Refactor and clean up GROWTH tiling schemes