This repository has been archived by the owner on Oct 21, 2024. It is now read-only.
Fix nested multiprocessing on import #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpsinger
force-pushed
the
fix-broken-process-pool
branch
2 times, most recently
from
30f756d
to
6655904
Compare
The `dorado-scheduling` script raised a `RuntimeError` error
because the `dorado.scheduling.mission` module called
`astropy.utils.download_files_in_parallel` on import.
The error message was:
```
An attempt has been made to start a new process before the
current process has finished its bootstrapping phase.
```
Fix this by moving the call to `download_files_in_parallel` inside
a function that is not called on import.
Fixes nasa#89.
lpsinger
force-pushed
the
fix-broken-process-pool
branch
from
6655904
to
469c394
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
==========================================
- Coverage 29.71% 28.78% -0.94%
==========================================
Files 38 38
Lines 1817 1817
==========================================
- Hits 540 523 -17
- Misses 1277 1294 +17 ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dorado-schedulingscript raised aRuntimeErrorerror because thedorado.scheduling.missionmodule calledastropy.utils.download_files_in_parallelon import.The error message was:
Fix this by moving the call to
download_files_in_parallelinside a function that is not called on import.Fixes #89.