Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #37, termination on strncpy #38

Merged
merged 1 commit into from
May 8, 2020

Conversation

jphickey
Copy link
Contributor

Describe the contribution
Fix possible non-termination of strings within command line parsing.
This generated a warning in GCC9.

Fixes #37

Testing performed
Build code with default config, SIMULATION=native BUILDTYPE=release on GCC 9.3.0.
Confirm successful build with no warning.

Expected behavior changes
No impact to behavior

System(s) tested on
Ubuntu 20.04 LTS 64 bit

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Fix possible non-termination of strings within command line parsing.
This generated a warning in GCC9.
@jphickey jphickey added CCB:Ready bug Something isn't working labels Apr 27, 2020
@astrogeco
Copy link
Contributor

CCB 2020-04-29 : APPROVED

@astrogeco astrogeco added CCB-20200429 CCB:Approved Indicates code approval by CCB and removed CCB:Ready labels May 5, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate May 8, 2020 19:21
@astrogeco astrogeco merged commit 32a9171 into nasa:integration-candidate May 8, 2020
@skliper skliper added this to the 3.2.0 milestone Jun 1, 2020
@skliper skliper modified the milestone: 3.2.0 Aug 21, 2020
@jphickey jphickey deleted the fix-37-stringops branch June 8, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CCB:Approved Indicates code approval by CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

String truncation warnings with newer GCC
3 participants