Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing implementation include paths #356

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Fixing implementation include paths #356

merged 3 commits into from
Nov 29, 2023

Conversation

LeStarch
Copy link
Collaborator

This fixes #355!

@LeStarch LeStarch requested a review from bocchino November 28, 2023 22:30
@LeStarch
Copy link
Collaborator Author

@thomas-bc here is the fix for the issue we discovered! It was not as simple as I first indicated, as we needed to:

  1. Acquire the Component symbol's location (FPP model file location defining symbol)
  2. Convert that to a full path
  3. Strip prefixes
  4. Add .hpp
  5. Pass to "make include statement" function (this was done already, but on erroneous input)

bocchino
bocchino approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I made the corresponding changes to the headers in the test implementation.

@bocchino
Copy link
Collaborator

I also refactored a bit to eliminate code duplication.

@bocchino
Copy link
Collaborator

bocchino commented Nov 29, 2023 •
edited
Loading

The CI failure is due to some issue with Python packages. It is unrelated to the changes in this PR.

@bocchino bocchino merged commit b32aa31 into nasa:main Nov 29, 2023
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bocchino bocchino bocchino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Template Generation Include Paths
2 participants
@LeStarch @bocchino