Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statemachine check #439

Merged
merged 67 commits into from
Jun 24, 2024
Merged

Statemachine check #439

merged 67 commits into from
Jun 24, 2024

Conversation

garthwatney
Copy link
Collaborator

@garthwatney garthwatney commented May 24, 2024 •
edited by bocchino
Loading

Added dependency analysis and semantic checking to state machines Phase 1.

Closes #436. Closes #437.

watney added 30 commits April 24, 2024 15:21
add state machine specs and defs
fd80cbe
Define the state-machine FPP syntax
6710493
More state-machine FPP syntax
a1ca161
Start defining AST for state machine
017e69f
Add example state machine fpp code
a6442da
Move all the state machine behavior specs to State-Machine-Behavior d…
7e9cfad 
…irectory
Try a couple of different fpp syntax for state machines
85a77a7
Add actions on initial transitions and explicitly represent junction …
68ff85f 
…behavior in the fpp
Update state machine syntax
4df4035
First cut at state machine syntax after reviews
0348890
Add parser for 'state machine'
a4cc7c0
Add parser for 'state machine instance'
2c31baa
Add state machine to component members
e42a8f2
Add state machine instance to component members
6eb6166
Update prettify, vim and emacs
35c635a
fpp-syntax source and test updated
120748c
fpp-format source and test updated for state machines
447c647
Incorporate Bocchino's comments on the state machine spec document
be9e193
Fix fpp-to-json test that failed because of keyword state
7cbd9ac
Incorporate state machine definition under module members
f22c47c
Update fpp-check for duplicate state machine definitions
a561e18
Merge remote-tracking branch 'fpp/main' into statemachine-merge
440f729
Add state machine example
ef767bc
Fix EnterSymbols for state machine
7eeab7f
Merge branch 'feature/state-machine' into statemachine-merge
201d437
Fix most of the tests except fpp-to-json
4f7fbe3
Merge branch 'feature/state-machine' into statemachine-merge
720e520
Merge branch 'feature/state-machine' into statemachine-merge
a053ecf
Merge branch 'statemachine-syntax' into statemachine-merge
774e837
Update the fpp-to-json test to pass
25a77a2
@garthwatney
Copy link
Collaborator Author

I created a state_machine_instance directory for state machine tests
I added checks for incorrect symbols in state machine instances.

@garthwatney garthwatney requested a review from bocchino June 21, 2024 00:25
bocchino
bocchino approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I added some tests.

@bocchino bocchino merged commit 7cc89ba into nasa:feature/state-machine Jun 24, 2024
This was referenced Jun 24, 2024
Closed
Closed
@garthwatney garthwatney deleted the statemachine-check branch August 1, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bocchino bocchino bocchino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garthwatney @bocchino