Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for duplicate file names #443

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Add unit test for duplicate file names #443

merged 1 commit into from
Jun 10, 2024

Conversation

jwest115
Copy link
Collaborator

@jwest115 jwest115 commented Jun 7, 2024 •
edited
Loading

Write fpp-to-dict output to txt file and compare against reference (similar to other tools). Added unit test case for duplicate file names.

@jwest115 jwest115 requested a review from bocchino June 7, 2024 22:51
@jwest115 jwest115 linked an issue Jun 7, 2024 that may be closed by this pull request
Add a unit test for duplicate JSON dictionary files #404
Closed
bocchino
bocchino reviewed Jun 8, 2024
View reviewed changes
Copy link
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Why are the empty files dataProducts.ref.txt and multipleTops.ref.txt checked in here? Do we need them?

@jwest115
Copy link
Collaborator Author

I don't think we need them, I decided to include them to keep things consistent with other tool unit tests, for example fpp-to-cpp https://github.com/nasa/fpp/blob/main/compiler/tools/fpp-to-cpp/test/enum/default.ref.txt.

@bocchino
Copy link
Collaborator

OK, I agree that makes sense now that we are checking for console output. Thanks!

bocchino
bocchino approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bocchino bocchino merged commit 9fd4653 into nasa:main Jun 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bocchino bocchino bocchino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a unit test for duplicate JSON dictionary files
2 participants
@jwest115 @bocchino