Remove FW_ARRAY_TO_STRING #375 #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 18, 2024 11:48
bocchino
reviewed
Jun 18, 2024
Remove unused, outdated code
bocchino
reviewed
Jun 18, 2024
compiler/lib/src/main/scala/codegen/CppWriter/EnumCppWriter.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FW_SERIALIZABLE_TO_STRINGinstead ofFW_ARRAY_TO_STRING|| FW_ENABLE_TEXT_LOGGINGin enum code gen. Per the static assertions in the F Prime config, if text logging is on, then serializable strings are on. See https://github.com/nasa/fprime/blob/af76f089e5aaee774d129e9005e19aaeab36e2f0/Fw/Cfg/ConfigCheck.cpp#L39-L42.Closes #375.