Updated XML and GDS limitations #402 #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We don't want to lose color-coding. That is very important for live testing. |
bocchino
approved these changes
Jun 25, 2024
Remove reference to Python generation. We don't do that any more.
thomas-bc
approved these changes
Jun 25, 2024
|
@timcanham agreed - FPP includes the limit info/colors in the dictionary. My comment above was mainly referring to F´ GDS, since it looks like it does not render the appropriate colors in the channel tab. @thomas-bc created an issue for that nasa/fprime#2754 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed XML and GDS limitations that are no longer relevant and/or fixed.
I removed any limitations that are related to XML to CPP since we no longer use the XML to generate CPP.
Also, for the XML limitation regarding limits for telemetry channels of array or struct types - I verified that the limits for these types are in the XML and JSON dictionary, however, the limits do not appears in the telemetry tab in the GDS. Based on #2754, this appears to be a bug in the GDS, so I think we can change this to a GDS limitation or leave it out... @bocchino let me know what you think!
Closes #402.