Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape special characters in XML attributes #458

Merged
merged 5 commits into from
Jun 27, 2024
Merged

Conversation

bocchino
Copy link
Collaborator

  • Update fpp-to-xml tests
  • Revise check-xml so it runs the XML autocoder to ensure that the XML is accepted, but doesn't attempt to compile the generated C++. This no longer works.

Closes #457.

bocchino added 3 commits June 26, 2024 16:04
Don't attempt to compile autocoded C++; the framework has diverged
from the Python autocoder
Add unit test
Update unit tests
@bocchino bocchino requested a review from jwest115 June 27, 2024 00:37
Revise unit tests
@bocchino bocchino changed the title Escape the character < in XML attributes Escape special characters in XML attributes Jun 27, 2024
@bocchino bocchino requested a review from timcanham June 27, 2024 15:56
@bocchino bocchino merged commit 9518488 into main Jun 27, 2024
11 checks passed
@bocchino bocchino deleted the issue-457-xml-escapes branch June 27, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fpp-to-xml] Escape special characters in XML attributes
2 participants