New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the state machine specification for do actions as lists #482

Merged

bocchino merged 8 commits into nasa:feature/state-machine-phase-2 from garthwatney:new-syntax-spec

Jul 31, 2024

Collaborator

garthwatney commented Jul 25, 2024 •

edited by bocchino

Loading

Factor the do syntax into a separate "do expression"
Replace optional action with action list in do expressions
Add entry and exit actions


          Update the state machine specification for do actions as lists

77cd2d1

garthwatney requested a review from bocchino

July 25, 2024 18:39

bocchino reviewed

View reviewed changes

docs/spec/State-Machine-Behavior-Elements/Do-Expressions.adoc Outdated Show resolved Hide resolved

bocchino reviewed

View reviewed changes

docs/spec/State-Machine-Behavior-Elements/Junction-Definitions.adoc Outdated Show resolved Hide resolved

bocchino reviewed

View reviewed changes

docs/spec/State-Machine-Behavior-Elements/State-Entry-Specifiers.adoc Outdated Show resolved Hide resolved

bocchino reviewed

View reviewed changes

docs/spec/State-Machine-Behavior-Elements/State-Transition-Specifiers.adoc Outdated Show resolved Hide resolved

bocchino reviewed

View reviewed changes

Collaborator

bocchino left a comment

Looks good! I added some comments. We need to add the new keywords in the lexical spec and in the other places (editors, code prettify).

bocchino reviewed

View reviewed changes

docs/spec/State-Machine-Behavior-Elements/State-Transition-Specifiers.adoc Outdated Show resolved Hide resolved


          Fix review from Bocchino

0699e95

garthwatney requested a review from bocchino

July 30, 2024 20:51

bocchino added 5 commits

July 31, 2024 11:19


          Add signal to run_prettify

b3448a6


          Revise state machine spec

4a66293


          Fix example code

6fc0810


          Revise examples in spec

8f375b2


          Revise state machine examples in spec

11eac5e

bocchino approved these changes

View reviewed changes

Collaborator

bocchino left a comment

Looks good!


          Merge remote-tracking branch 'nasa/feature/state-machine-phase-2' int…

…o new-syntax-spec

bocchino merged commit 7637728 into nasa:feature/state-machine-phase-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet