Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing data product pre message hooks #490

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

LeStarch
Copy link
Collaborator

@LeStarch LeStarch commented Aug 8, 2024

Most ports only have preMsgHook when operating as async. However, data product ports erroneously added preMsgHook to every use (guarded, sync, and async). This fixes this oversight.

@LeStarch LeStarch requested a review from bocchino August 8, 2024 16:30
Copy link
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bocchino bocchino merged commit 2ab0edd into main Aug 12, 2024
11 checks passed
@bocchino bocchino deleted the fix/dp-async-pre-hook branch August 12, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants