-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for queue overflow hook methods #492
Conversation
Looks good! Since we are no longer actively developing the XML model, I suggest we convert |
@bocchino did the downgrade from 'hook' to 'drop' in XML generation, along with a test that proves the feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Peer review notes:
- rename
overflowHook
tocmdOverflowHook
for commands, following thecmdHandler
pattern for commands vshandler
for ports
compiler/lib/src/main/scala/codegen/CppWriter/ComponentCppWriter/ComponentCppWriterUtils.scala
Outdated
Show resolved
Hide resolved
compiler/lib/src/main/scala/codegen/CppWriter/ComponentCppWriter/ComponentCppWriterUtils.scala
Show resolved
Hide resolved
compiler/lib/src/main/scala/codegen/CppWriter/ComponentCppWriter/ComponentImplWriter.scala
Outdated
Show resolved
Hide resolved
compiler/lib/src/main/scala/codegen/CppWriter/ComponentCppWriter/ComponentImplWriter.scala
Outdated
Show resolved
Hide resolved
compiler/lib/src/main/scala/codegen/XmlFppWriter/ComponentXmlFppWriter.scala
Outdated
Show resolved
Hide resolved
e7f172f
to
59a0e6f
Compare
@bocchino I have fixed all review comments, please let me know if anything else is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! This is a good addition to the modeling and code gen.
@thomas-bc This looks good to me. Once you review and approve, I will merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🇮🇹
When a port is set to 'drop' on overflow, there can be a memory leak should the port contain a resource that needed dedicated deallocation (e.g.
Fw.Buffer
). To fix this, we add ahook
overflow option, which passes the port arguments to a function for handling (e.g. call to deallocate).This PR contains the following items:
F Prime integration work (to go):