Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/real performance #12

Merged
merged 5 commits into from
Aug 3, 2021
Merged

Conversation

LeStarch
Copy link
Collaborator

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Making charts, but faster.

@LeStarch LeStarch requested a review from metzdigital July 29, 2021 20:44
@github-actions
Copy link

@check-spelling-bot Report

🔴 Please review

Unrecognized words (30)
Akihiko
Bezier
cmax
cmin
datalabels
debounce
Debounced
diffrent
framerate
ilen
instanceof
interop
Kusanagi
mousedown
mousemove
mouseout
mouseup
panend
panmove
panstart
pinchend
pinchstart
plottable
registerables
scriptable
Syncronize
Timescales
timeseries
transitionable
xy
Available dictionaries could cover words not in the dictionary

cspell:cpp/cpp.txt (104293) covers 129 of them
cspell:filetypes/filetypes.txt (337) covers 43 of them
cspell:html/html.txt (542) covers 39 of them
cspell:css/css.txt (993) covers 38 of them
cspell:python/python.txt (364) covers 30 of them
cspell:django/django.txt (2342) covers 22 of them
cspell:aws/aws.txt (1485) covers 18 of them
cspell:golang/go.txt (7745) covers 16 of them
cspell:fullstack/fullstack.txt (181) covers 13 of them
cspell:npm/npm.txt (671) covers 10 of them
cspell:java/java.txt (33524) covers 9 of them
cspell:lua/lua.txt (391) covers 6 of them
cspell:rust/rust.txt (112) covers 5 of them
cspell:csharp/csharp.txt (123) covers 5 of them
cspell:scala/scala.txt (2752) covers 4 of them
cspell:php/php.txt (9785) covers 4 of them
cspell:ruby/ruby.txt (354) covers 3 of them
cspell:dotnet/dotnet.txt (9824) covers 3 of them
cspell:node/node.txt (9611) covers 1 of them
cspell:bash/bash-words.txt (22) covers 1 of them

Consider adding them using:

      with:
        extra_dictionaries:
          cspell:cpp/cpp.txt
          cspell:filetypes/filetypes.txt
          cspell:html/html.txt
          cspell:css/css.txt
          cspell:python/python.txt
          cspell:django/django.txt
          cspell:aws/aws.txt
          cspell:golang/go.txt
          cspell:fullstack/fullstack.txt
          cspell:npm/npm.txt
          cspell:java/java.txt
          cspell:lua/lua.txt
          cspell:rust/rust.txt
          cspell:csharp/csharp.txt
          cspell:scala/scala.txt
          cspell:php/php.txt
          cspell:ruby/ruby.txt
          cspell:dotnet/dotnet.txt
          cspell:node/node.txt
          cspell:bash/bash-words.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
To accept these unrecognized words as correct, run the following commands

... in a clone of the git@github.com:LeStarch/fprime-gds.git repository
on the update/real-performance branch:

(cd $(git rev-parse --show-toplevel)
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"Akihiko Bezier cmax cmin datalabels debounce Debounced diffrent framerate ilen instanceof interop Kusanagi mousedown mousemove mouseout mouseup panend panmove panstart pinchend pinchstart plottable registerables scriptable Syncronize Timescales timeseries transitionable xy "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
)

@lgtm-com
Copy link

lgtm-com bot commented Jul 29, 2021

This pull request introduces 2 alerts when merging 8a6c204 into 0a374a4 - view on LGTM.com

new alerts:

  • 1 for Useless conditional
  • 1 for Ignoring result from pure array method

@LeStarch LeStarch force-pushed the update/real-performance branch from 8a6c204 to dfe4d99 Compare July 29, 2021 21:40
@github-actions
Copy link

@check-spelling-bot Report

🔴 Please review

Unrecognized words (30)
Akihiko
Bezier
cmax
cmin
datalabels
debounce
Debounced
diffrent
framerate
ilen
instanceof
interop
Kusanagi
mousedown
mousemove
mouseout
mouseup
panend
panmove
panstart
pinchend
pinchstart
plottable
registerables
scriptable
Syncronize
Timescales
timeseries
transitionable
xy
Available dictionaries could cover words not in the dictionary

cspell:cpp/cpp.txt (104293) covers 129 of them
cspell:filetypes/filetypes.txt (337) covers 43 of them
cspell:html/html.txt (542) covers 39 of them
cspell:css/css.txt (993) covers 38 of them
cspell:python/python.txt (364) covers 30 of them
cspell:django/django.txt (2342) covers 22 of them
cspell:aws/aws.txt (1485) covers 18 of them
cspell:golang/go.txt (7745) covers 16 of them
cspell:fullstack/fullstack.txt (181) covers 13 of them
cspell:npm/npm.txt (671) covers 10 of them
cspell:java/java.txt (33524) covers 9 of them
cspell:lua/lua.txt (391) covers 6 of them
cspell:rust/rust.txt (112) covers 5 of them
cspell:csharp/csharp.txt (123) covers 5 of them
cspell:scala/scala.txt (2752) covers 4 of them
cspell:php/php.txt (9785) covers 4 of them
cspell:ruby/ruby.txt (354) covers 3 of them
cspell:dotnet/dotnet.txt (9824) covers 3 of them
cspell:node/node.txt (9611) covers 1 of them
cspell:bash/bash-words.txt (22) covers 1 of them

Consider adding them using:

      with:
        extra_dictionaries:
          cspell:cpp/cpp.txt
          cspell:filetypes/filetypes.txt
          cspell:html/html.txt
          cspell:css/css.txt
          cspell:python/python.txt
          cspell:django/django.txt
          cspell:aws/aws.txt
          cspell:golang/go.txt
          cspell:fullstack/fullstack.txt
          cspell:npm/npm.txt
          cspell:java/java.txt
          cspell:lua/lua.txt
          cspell:rust/rust.txt
          cspell:csharp/csharp.txt
          cspell:scala/scala.txt
          cspell:php/php.txt
          cspell:ruby/ruby.txt
          cspell:dotnet/dotnet.txt
          cspell:node/node.txt
          cspell:bash/bash-words.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
To accept these unrecognized words as correct, run the following commands

... in a clone of the git@github.com:LeStarch/fprime-gds.git repository
on the update/real-performance branch:

(cd $(git rev-parse --show-toplevel)
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"Akihiko Bezier cmax cmin datalabels debounce Debounced diffrent framerate ilen instanceof interop Kusanagi mousedown mousemove mouseout mouseup panend panmove panstart pinchend pinchstart plottable registerables scriptable Syncronize Timescales timeseries transitionable xy "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
)

@lgtm-com
Copy link

lgtm-com bot commented Jul 29, 2021

This pull request introduces 2 alerts when merging dfe4d99 into 0a374a4 - view on LGTM.com

new alerts:

  • 1 for Useless conditional
  • 1 for Ignoring result from pure array method

@LeStarch LeStarch force-pushed the update/real-performance branch from dfe4d99 to f8c3627 Compare July 29, 2021 21:45
@github-actions
Copy link

@check-spelling-bot Report

🔴 Please review

Unrecognized words (30)
Akihiko
Bezier
cmax
cmin
datalabels
debounce
Debounced
diffrent
framerate
ilen
instanceof
interop
Kusanagi
mousedown
mousemove
mouseout
mouseup
panend
panmove
panstart
pinchend
pinchstart
plottable
registerables
scriptable
Syncronize
Timescales
timeseries
transitionable
xy
Available dictionaries could cover words not in the dictionary

cspell:cpp/cpp.txt (104293) covers 129 of them
cspell:filetypes/filetypes.txt (337) covers 43 of them
cspell:html/html.txt (542) covers 39 of them
cspell:css/css.txt (993) covers 38 of them
cspell:python/python.txt (364) covers 30 of them
cspell:django/django.txt (2342) covers 22 of them
cspell:aws/aws.txt (1485) covers 18 of them
cspell:golang/go.txt (7745) covers 16 of them
cspell:fullstack/fullstack.txt (181) covers 13 of them
cspell:npm/npm.txt (671) covers 10 of them
cspell:java/java.txt (33524) covers 9 of them
cspell:lua/lua.txt (391) covers 6 of them
cspell:rust/rust.txt (112) covers 5 of them
cspell:csharp/csharp.txt (123) covers 5 of them
cspell:scala/scala.txt (2752) covers 4 of them
cspell:php/php.txt (9785) covers 4 of them
cspell:ruby/ruby.txt (354) covers 3 of them
cspell:dotnet/dotnet.txt (9824) covers 3 of them
cspell:node/node.txt (9611) covers 1 of them
cspell:bash/bash-words.txt (22) covers 1 of them

Consider adding them using:

      with:
        extra_dictionaries:
          cspell:cpp/cpp.txt
          cspell:filetypes/filetypes.txt
          cspell:html/html.txt
          cspell:css/css.txt
          cspell:python/python.txt
          cspell:django/django.txt
          cspell:aws/aws.txt
          cspell:golang/go.txt
          cspell:fullstack/fullstack.txt
          cspell:npm/npm.txt
          cspell:java/java.txt
          cspell:lua/lua.txt
          cspell:rust/rust.txt
          cspell:csharp/csharp.txt
          cspell:scala/scala.txt
          cspell:php/php.txt
          cspell:ruby/ruby.txt
          cspell:dotnet/dotnet.txt
          cspell:node/node.txt
          cspell:bash/bash-words.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
To accept these unrecognized words as correct, run the following commands

... in a clone of the git@github.com:LeStarch/fprime-gds.git repository
on the update/real-performance branch:

(cd $(git rev-parse --show-toplevel)
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"Akihiko Bezier cmax cmin datalabels debounce Debounced diffrent framerate ilen instanceof interop Kusanagi mousedown mousemove mouseout mouseup panend panmove panstart pinchend pinchstart plottable registerables scriptable Syncronize Timescales timeseries transitionable xy "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
)

@lgtm-com
Copy link

lgtm-com bot commented Jul 29, 2021

This pull request introduces 2 alerts when merging f8c3627 into 0a374a4 - view on LGTM.com

new alerts:

  • 1 for Useless conditional
  • 1 for Ignoring result from pure array method

@github-actions
Copy link

github-actions bot commented Aug 2, 2021

@check-spelling-bot Report

🔴 Please review

Unrecognized words (6)
conifguring
framerate
Syncronize
timescales
xy
zoomable
Previously acknowledged words that are now absent ctx nagix
Available dictionaries could cover words not in the dictionary

cspell:cpp/cpp.txt (104293) covers 127 of them
cspell:filetypes/filetypes.txt (337) covers 43 of them
cspell:html/html.txt (542) covers 39 of them
cspell:css/css.txt (993) covers 38 of them
cspell:python/python.txt (364) covers 30 of them
cspell:django/django.txt (2342) covers 22 of them
cspell:aws/aws.txt (1485) covers 18 of them
cspell:golang/go.txt (7745) covers 16 of them
cspell:fullstack/fullstack.txt (181) covers 13 of them
cspell:npm/npm.txt (671) covers 9 of them
cspell:java/java.txt (33524) covers 9 of them
cspell:lua/lua.txt (391) covers 6 of them
cspell:rust/rust.txt (112) covers 5 of them
cspell:csharp/csharp.txt (123) covers 5 of them
cspell:scala/scala.txt (2752) covers 4 of them
cspell:ruby/ruby.txt (354) covers 3 of them
cspell:php/php.txt (9785) covers 3 of them
cspell:dotnet/dotnet.txt (9824) covers 3 of them
cspell:node/node.txt (9611) covers 1 of them
cspell:bash/bash-words.txt (22) covers 1 of them

Consider adding them using:

      with:
        extra_dictionaries:
          cspell:cpp/cpp.txt
          cspell:filetypes/filetypes.txt
          cspell:html/html.txt
          cspell:css/css.txt
          cspell:python/python.txt
          cspell:django/django.txt
          cspell:aws/aws.txt
          cspell:golang/go.txt
          cspell:fullstack/fullstack.txt
          cspell:npm/npm.txt
          cspell:java/java.txt
          cspell:lua/lua.txt
          cspell:rust/rust.txt
          cspell:csharp/csharp.txt
          cspell:scala/scala.txt
          cspell:ruby/ruby.txt
          cspell:php/php.txt
          cspell:dotnet/dotnet.txt
          cspell:node/node.txt
          cspell:bash/bash-words.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the git@github.com:LeStarch/fprime-gds.git repository
on the update/real-performance branch:

(cd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"ctx nagix "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"conifguring framerate Syncronize timescales xy zoomable "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
)

@lgtm-com
Copy link

lgtm-com bot commented Aug 2, 2021

This pull request introduces 3 alerts when merging 6b72162 into 0a374a4 - view on LGTM.com

new alerts:

  • 1 for Useless conditional
  • 1 for Ignoring result from pure array method
  • 1 for Invocation of non-function

@github-actions
Copy link

github-actions bot commented Aug 2, 2021

@check-spelling-bot Report

🔴 Please review

Unrecognized words (6)
conifguring
framerate
Syncronize
timescales
xy
zoomable
Previously acknowledged words that are now absent ctx kets nagix
Available dictionaries could cover words not in the dictionary

cspell:cpp/cpp.txt (104293) covers 127 of them
cspell:filetypes/filetypes.txt (337) covers 43 of them
cspell:html/html.txt (542) covers 39 of them
cspell:css/css.txt (993) covers 38 of them
cspell:python/python.txt (364) covers 30 of them
cspell:django/django.txt (2342) covers 22 of them
cspell:aws/aws.txt (1485) covers 18 of them
cspell:golang/go.txt (7745) covers 16 of them
cspell:fullstack/fullstack.txt (181) covers 13 of them
cspell:npm/npm.txt (671) covers 9 of them
cspell:java/java.txt (33524) covers 9 of them
cspell:lua/lua.txt (391) covers 6 of them
cspell:rust/rust.txt (112) covers 5 of them
cspell:csharp/csharp.txt (123) covers 5 of them
cspell:scala/scala.txt (2752) covers 4 of them
cspell:ruby/ruby.txt (354) covers 3 of them
cspell:php/php.txt (9785) covers 3 of them
cspell:dotnet/dotnet.txt (9824) covers 3 of them
cspell:node/node.txt (9611) covers 1 of them
cspell:bash/bash-words.txt (22) covers 1 of them

Consider adding them using:

      with:
        extra_dictionaries:
          cspell:cpp/cpp.txt
          cspell:filetypes/filetypes.txt
          cspell:html/html.txt
          cspell:css/css.txt
          cspell:python/python.txt
          cspell:django/django.txt
          cspell:aws/aws.txt
          cspell:golang/go.txt
          cspell:fullstack/fullstack.txt
          cspell:npm/npm.txt
          cspell:java/java.txt
          cspell:lua/lua.txt
          cspell:rust/rust.txt
          cspell:csharp/csharp.txt
          cspell:scala/scala.txt
          cspell:ruby/ruby.txt
          cspell:php/php.txt
          cspell:dotnet/dotnet.txt
          cspell:node/node.txt
          cspell:bash/bash-words.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the git@github.com:LeStarch/fprime-gds.git repository
on the update/real-performance branch:

(cd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"ctx kets nagix "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"conifguring framerate Syncronize timescales xy zoomable "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
)

@LeStarch LeStarch force-pushed the update/real-performance branch from d874ad6 to 68798a2 Compare August 2, 2021 22:43
@github-actions
Copy link

github-actions bot commented Aug 2, 2021

@check-spelling-bot Report

🔴 Please review

Unrecognized words (3)
conifguring
Syncronize
zoomable
Previously acknowledged words that are now absent ctx kets nagix
Available dictionaries could cover words not in the dictionary

cspell:cpp/cpp.txt (104293) covers 127 of them
cspell:filetypes/filetypes.txt (337) covers 43 of them
cspell:html/html.txt (542) covers 39 of them
cspell:css/css.txt (993) covers 38 of them
cspell:python/python.txt (364) covers 30 of them
cspell:django/django.txt (2342) covers 22 of them
cspell:aws/aws.txt (1485) covers 18 of them
cspell:golang/go.txt (7745) covers 16 of them
cspell:fullstack/fullstack.txt (181) covers 13 of them
cspell:npm/npm.txt (671) covers 9 of them
cspell:java/java.txt (33524) covers 9 of them
cspell:lua/lua.txt (391) covers 6 of them
cspell:rust/rust.txt (112) covers 5 of them
cspell:csharp/csharp.txt (123) covers 5 of them
cspell:scala/scala.txt (2752) covers 4 of them
cspell:ruby/ruby.txt (354) covers 3 of them
cspell:php/php.txt (9785) covers 3 of them
cspell:dotnet/dotnet.txt (9824) covers 3 of them
cspell:node/node.txt (9611) covers 1 of them
cspell:bash/bash-words.txt (22) covers 1 of them

Consider adding them using:

      with:
        extra_dictionaries:
          cspell:cpp/cpp.txt
          cspell:filetypes/filetypes.txt
          cspell:html/html.txt
          cspell:css/css.txt
          cspell:python/python.txt
          cspell:django/django.txt
          cspell:aws/aws.txt
          cspell:golang/go.txt
          cspell:fullstack/fullstack.txt
          cspell:npm/npm.txt
          cspell:java/java.txt
          cspell:lua/lua.txt
          cspell:rust/rust.txt
          cspell:csharp/csharp.txt
          cspell:scala/scala.txt
          cspell:ruby/ruby.txt
          cspell:php/php.txt
          cspell:dotnet/dotnet.txt
          cspell:node/node.txt
          cspell:bash/bash-words.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the git@github.com:LeStarch/fprime-gds.git repository
on the update/real-performance branch:

(cd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"ctx kets nagix "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"conifguring Syncronize zoomable "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
)

@LeStarch LeStarch force-pushed the update/real-performance branch from 68798a2 to b3b8c30 Compare August 2, 2021 22:46
@lgtm-com
Copy link

lgtm-com bot commented Aug 2, 2021

This pull request introduces 4 alerts when merging b3b8c30 into 0a374a4 - view on LGTM.com

new alerts:

  • 1 for Useless conditional
  • 1 for Unused local variable
  • 1 for Ignoring result from pure array method
  • 1 for Uncontrolled data used in path expression

…dding, removing, fixing timescales, also fixed bug where fixed timescales for a removed chart would cause the remaining charts to freeze up
Copy link

@metzdigital metzdigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it, looks good.

@LeStarch LeStarch merged commit 9994195 into nasa:devel Aug 3, 2021
@lgtm-com
Copy link

lgtm-com bot commented Aug 3, 2021

This pull request introduces 3 alerts when merging 575d65b into 4e54110 - view on LGTM.com

new alerts:

  • 1 for Useless conditional
  • 1 for Unused local variable
  • 1 for Uncontrolled data used in path expression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants