Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/fancy tab #13

Merged
merged 13 commits into from
Aug 3, 2021
Merged

Update/fancy tab #13

merged 13 commits into from
Aug 3, 2021

Conversation

LeStarch
Copy link
Collaborator

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

A description of the changes contained in the PR.

Rationale

A rationale for this change. e.g. fixes bug, or most projects need XYZ feature.

Testing/Review Recommendations

Fill in testing procedures, specific items to focus on for review, or other info to help the team verify these changes are flight-quality.

Future Work

Note any additional work that will be done relating to this issue.

@github-actions
Copy link

@check-spelling-bot Report

🔴 Please review

Unrecognized words (165)
activedescendant
Addrs
autocapitalize
autocompleter
autocompletion
autocorrect
beforeinput
beforeprint
bitmask
bparse
brk
btoa
bugzilla
changeset
closebrackets
cmp
codemirror
codepoint
compat
compositionend
compositionstart
compositionupdate
contenteditable
contextmenu
coords
crelt
cx
debounce
Dedup
deps
deref
DOMAt
doy
dragstart
ecx
ek
elts
emacs
eor
expr
fallthrough
FIXME
fx
getdx
getdy
grammer
gx
heightmap
hift
highlighter
hightest
higlighting
idx
instanceof
invididual
itis
iz
jj
jkl
keybindings
keyboardselection
keydown
keymap
keyup
kh
lezer
lineboundary
linewise
linting
marijnh
matchbrackets
mergeable
mno
mousedown
mouseleave
mousemove
mouseup
mozilla
NFKD
NLR
noncomplete
npm
nrt
NSM
offet
onchange
onclick
onerror
onkeydown
onkeyup
onmousedown
onsubmit
OOQO
OPO
OPOOOd
OPPQ
OSPR
OSQO
overapproximation
overriden
OVXOWXOXXOYXO
Pfl
placeholders
pointerselection
POOO
Ppq
PQQO
pqr
prebuilt
Pz
qa
QPO
QQO
QVQPOOP
QVQPOOPi
QX
rangeset
rects
regexp
reindent
reindentation
relayout
reparse
respresents
rollup
rtl
rv
scroller
selectionchange
shadowroot
sor
specializers
spellcheck
SROr
Stdio
strikethrough
strs
stu
subtag
sucessfully
tempdir
textfield
Theif
tok
tokenizer
touchmove
touchstart
traveral
TROSTYUZQSORVSQZUR
TWQ
ucd
uncomment
unneccesary
unregistering
Unrelatedly
UPX
viewports
WDnr
webpack
xmlns
XUWQ
YZzrs
ZP
ZUWQ
ZWJ
Previously acknowledged words that are now absent Emoji Linux MULTILINE Uint
Available dictionaries could cover words not in the dictionary

cspell:cpp/cpp.txt (104293) covers 150 of them
cspell:html/html.txt (542) covers 46 of them
cspell:filetypes/filetypes.txt (337) covers 43 of them
cspell:css/css.txt (993) covers 41 of them
cspell:python/python.txt (364) covers 30 of them
cspell:django/django.txt (2342) covers 23 of them
cspell:golang/go.txt (7745) covers 20 of them
cspell:aws/aws.txt (1485) covers 18 of them
cspell:fullstack/fullstack.txt (181) covers 16 of them
cspell:npm/npm.txt (671) covers 14 of them
cspell:java/java.txt (33524) covers 9 of them
cspell:lua/lua.txt (391) covers 7 of them
cspell:rust/rust.txt (112) covers 6 of them
cspell:csharp/csharp.txt (123) covers 6 of them
cspell:scala/scala.txt (2752) covers 5 of them
cspell:php/php.txt (9785) covers 4 of them
cspell:ruby/ruby.txt (354) covers 3 of them
cspell:dotnet/dotnet.txt (9824) covers 3 of them
cspell:node/node.txt (9611) covers 2 of them
cspell:bash/bash-words.txt (22) covers 1 of them

Consider adding them using:

      with:
        extra_dictionaries:
          cspell:cpp/cpp.txt
          cspell:html/html.txt
          cspell:filetypes/filetypes.txt
          cspell:css/css.txt
          cspell:python/python.txt
          cspell:django/django.txt
          cspell:golang/go.txt
          cspell:aws/aws.txt
          cspell:fullstack/fullstack.txt
          cspell:npm/npm.txt
          cspell:java/java.txt
          cspell:lua/lua.txt
          cspell:rust/rust.txt
          cspell:csharp/csharp.txt
          cspell:scala/scala.txt
          cspell:php/php.txt
          cspell:ruby/ruby.txt
          cspell:dotnet/dotnet.txt
          cspell:node/node.txt
          cspell:bash/bash-words.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the git@github.com:LeStarch/fprime-gds.git repository
on the update/fancy-tab branch:

(cd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"Emoji Linux MULTILINE Uint "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"activedescendant Addrs autocapitalize autocompleter autocompletion autocorrect beforeinput beforeprint bitmask bparse brk btoa bugzilla changeset closebrackets cmp codemirror codepoint compat compositionend compositionstart compositionupdate contenteditable contextmenu coords crelt cx debounce Dedup deps deref DOMAt doy dragstart ecx ek elts emacs emoji eor expr fallthrough FIXME fx getdx getdy grammer gx heightmap hift highlighter hightest higlighting idx instanceof invididual itis iz jj jkl keybindings keyboardselection keydown keymap keyup kh lezer lineboundary linewise linting linux marijnh matchbrackets mergeable mno mousedown mouseleave mousemove mouseup mozilla multiline NFKD NLR noncomplete npm nrt NSM offet onchange onclick onerror onkeydown onkeyup onmousedown onsubmit OOQO OPO OPOOOd OPPQ OSPR OSQO overapproximation overriden OVXOWXOXXOYXO Pfl placeholders pointerselection POOO Ppq PQQO pqr prebuilt Pz qa QPO QQO QVQPOOP QVQPOOPi QX rangeset rects regexp reindent reindentation relayout reparse respresents rollup rtl rv scroller selectionchange shadowroot sor specializers spellcheck SROr Stdio strikethrough strs stu subtag sucessfully tempdir textfield Theif tok tokenizer touchmove touchstart traveral TROSTYUZQSORVSQZUR TWQ ucd uint uncomment unneccesary unregistering Unrelatedly UPX viewports WDnr webpack xmlns XUWQ YZzrs ZP ZUWQ ZWJ "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
)

@lgtm-com
Copy link

lgtm-com bot commented Jul 31, 2021

This pull request introduces 4 alerts when merging 01655cc into 0a374a4 - view on LGTM.com

new alerts:

  • 2 for Except block handles 'BaseException'
  • 2 for Unused variable, import, function or class

@github-actions
Copy link

@check-spelling-bot Report

🔴 Please review

Unrecognized words (168)
activedescendant
Addrs
adrianheine
autocapitalize
autocompleter
autocompletion
autocorrect
beforeinput
beforeprint
bitmask
bparse
brk
btoa
bugzilla
changeset
closebrackets
cmp
codemirror
codepoint
compat
compositionend
compositionstart
compositionupdate
contenteditable
contextmenu
coords
crelt
cx
debounce
Dedup
deps
deref
DOMAt
doy
dragstart
ecx
ek
elts
emacs
eor
expr
fallthrough
FIXME
fx
getdx
getdy
gmail
grammer
gx
Haverbeke
heightmap
hift
highlighter
hightest
higlighting
idx
instanceof
invididual
itis
iz
jj
jkl
keybindings
keyboardselection
keydown
keymap
keyup
kh
lezer
lineboundary
linewise
linting
marijnh
matchbrackets
mergeable
mno
mousedown
mouseleave
mousemove
mouseup
mozilla
NFKD
NLR
noncomplete
npm
nrt
NSM
offet
onchange
onclick
onerror
onkeydown
onkeyup
onmousedown
onsubmit
OOQO
OPO
OPOOOd
OPPQ
OSPR
OSQO
overapproximation
overriden
OVXOWXOXXOYXO
Pfl
placeholders
pointerselection
POOO
Ppq
PQQO
pqr
prebuilt
Pz
qa
QPO
QQO
QVQPOOP
QVQPOOPi
QX
rangeset
rects
regexp
reindent
reindentation
relayout
reparse
respresents
rollup
rtl
rv
scroller
selectionchange
shadowroot
sor
specializers
spellcheck
SROr
Stdio
strikethrough
strs
stu
subtag
sucessfully
tempdir
textfield
Theif
tok
tokenizer
touchmove
touchstart
traveral
TROSTYUZQSORVSQZUR
TWQ
ucd
uncomment
unneccesary
unregistering
Unrelatedly
UPX
viewports
WDnr
webpack
xmlns
XUWQ
YZzrs
ZP
ZUWQ
ZWJ
Previously acknowledged words that are now absent Emoji Linux MULTILINE Uint
Available dictionaries could cover words not in the dictionary

cspell:cpp/cpp.txt (104293) covers 151 of them
cspell:html/html.txt (542) covers 46 of them
cspell:filetypes/filetypes.txt (337) covers 43 of them
cspell:css/css.txt (993) covers 41 of them
cspell:python/python.txt (364) covers 30 of them
cspell:django/django.txt (2342) covers 23 of them
cspell:golang/go.txt (7745) covers 20 of them
cspell:aws/aws.txt (1485) covers 18 of them
cspell:fullstack/fullstack.txt (181) covers 17 of them
cspell:npm/npm.txt (671) covers 14 of them
cspell:java/java.txt (33524) covers 9 of them
cspell:lua/lua.txt (391) covers 7 of them
cspell:rust/rust.txt (112) covers 6 of them
cspell:csharp/csharp.txt (123) covers 6 of them
cspell:scala/scala.txt (2752) covers 5 of them
cspell:php/php.txt (9785) covers 4 of them
cspell:ruby/ruby.txt (354) covers 3 of them
cspell:dotnet/dotnet.txt (9824) covers 3 of them
cspell:node/node.txt (9611) covers 2 of them
cspell:bash/bash-words.txt (22) covers 1 of them

Consider adding them using:

      with:
        extra_dictionaries:
          cspell:cpp/cpp.txt
          cspell:html/html.txt
          cspell:filetypes/filetypes.txt
          cspell:css/css.txt
          cspell:python/python.txt
          cspell:django/django.txt
          cspell:golang/go.txt
          cspell:aws/aws.txt
          cspell:fullstack/fullstack.txt
          cspell:npm/npm.txt
          cspell:java/java.txt
          cspell:lua/lua.txt
          cspell:rust/rust.txt
          cspell:csharp/csharp.txt
          cspell:scala/scala.txt
          cspell:php/php.txt
          cspell:ruby/ruby.txt
          cspell:dotnet/dotnet.txt
          cspell:node/node.txt
          cspell:bash/bash-words.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the git@github.com:LeStarch/fprime-gds.git repository
on the update/fancy-tab branch:

(cd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"Emoji Linux MULTILINE Uint "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"activedescendant Addrs adrianheine autocapitalize autocompleter autocompletion autocorrect beforeinput beforeprint bitmask bparse brk btoa bugzilla changeset closebrackets cmp codemirror codepoint compat compositionend compositionstart compositionupdate contenteditable contextmenu coords crelt cx debounce Dedup deps deref DOMAt doy dragstart ecx ek elts emacs emoji eor expr fallthrough FIXME fx getdx getdy gmail grammer gx Haverbeke heightmap hift highlighter hightest higlighting idx instanceof invididual itis iz jj jkl keybindings keyboardselection keydown keymap keyup kh lezer lineboundary linewise linting linux marijnh matchbrackets mergeable mno mousedown mouseleave mousemove mouseup mozilla multiline NFKD NLR noncomplete npm nrt NSM offet onchange onclick onerror onkeydown onkeyup onmousedown onsubmit OOQO OPO OPOOOd OPPQ OSPR OSQO overapproximation overriden OVXOWXOXXOYXO Pfl placeholders pointerselection POOO Ppq PQQO pqr prebuilt Pz qa QPO QQO QVQPOOP QVQPOOPi QX rangeset rects regexp reindent reindentation relayout reparse respresents rollup rtl rv scroller selectionchange shadowroot sor specializers spellcheck SROr Stdio strikethrough strs stu subtag sucessfully tempdir textfield Theif tok tokenizer touchmove touchstart traveral TROSTYUZQSORVSQZUR TWQ ucd uint uncomment unneccesary unregistering Unrelatedly UPX viewports WDnr webpack xmlns XUWQ YZzrs ZP ZUWQ ZWJ "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
)

@lgtm-com
Copy link

lgtm-com bot commented Jul 31, 2021

This pull request introduces 3 alerts when merging 708a0f1 into 0a374a4 - view on LGTM.com

new alerts:

  • 2 for Except block handles 'BaseException'
  • 1 for Unused variable, import, function or class

@github-actions
Copy link

@check-spelling-bot Report

🔴 Please review

Unrecognized words (168)
activedescendant
Addrs
adrianheine
autocapitalize
autocompleter
autocompletion
autocorrect
beforeinput
beforeprint
bitmask
bparse
brk
btoa
bugzilla
changeset
closebrackets
cmp
codemirror
codepoint
compat
compositionend
compositionstart
compositionupdate
contenteditable
contextmenu
coords
crelt
cx
debounce
Dedup
deps
deref
DOMAt
doy
dragstart
ecx
ek
elts
emacs
eor
expr
fallthrough
FIXME
fx
getdx
getdy
gmail
grammer
gx
Haverbeke
heightmap
hift
highlighter
hightest
higlighting
idx
instanceof
invididual
itis
iz
jj
jkl
keybindings
keyboardselection
keydown
keymap
keyup
kh
lezer
lineboundary
linewise
linting
marijnh
matchbrackets
mergeable
mno
mousedown
mouseleave
mousemove
mouseup
mozilla
NFKD
NLR
noncomplete
npm
nrt
NSM
offet
onchange
onclick
onerror
onkeydown
onkeyup
onmousedown
onsubmit
OOQO
OPO
OPOOOd
OPPQ
OSPR
OSQO
overapproximation
overriden
OVXOWXOXXOYXO
Pfl
placeholders
pointerselection
POOO
Ppq
PQQO
pqr
prebuilt
Pz
qa
QPO
QQO
QVQPOOP
QVQPOOPi
QX
rangeset
rects
regexp
reindent
reindentation
relayout
reparse
respresents
rollup
rtl
rv
scroller
selectionchange
shadowroot
sor
specializers
spellcheck
SROr
Stdio
strikethrough
strs
stu
subtag
sucessfully
tempdir
textfield
Theif
tok
tokenizer
touchmove
touchstart
traveral
TROSTYUZQSORVSQZUR
TWQ
ucd
uncomment
unneccesary
unregistering
Unrelatedly
UPX
viewports
WDnr
webpack
xmlns
XUWQ
YZzrs
ZP
ZUWQ
ZWJ
Previously acknowledged words that are now absent Emoji Linux MULTILINE Uint
Available dictionaries could cover words not in the dictionary

cspell:cpp/cpp.txt (104293) covers 151 of them
cspell:html/html.txt (542) covers 46 of them
cspell:filetypes/filetypes.txt (337) covers 43 of them
cspell:css/css.txt (993) covers 41 of them
cspell:python/python.txt (364) covers 30 of them
cspell:django/django.txt (2342) covers 23 of them
cspell:golang/go.txt (7745) covers 20 of them
cspell:aws/aws.txt (1485) covers 18 of them
cspell:fullstack/fullstack.txt (181) covers 17 of them
cspell:npm/npm.txt (671) covers 14 of them
cspell:java/java.txt (33524) covers 9 of them
cspell:lua/lua.txt (391) covers 7 of them
cspell:rust/rust.txt (112) covers 6 of them
cspell:csharp/csharp.txt (123) covers 6 of them
cspell:scala/scala.txt (2752) covers 5 of them
cspell:php/php.txt (9785) covers 4 of them
cspell:ruby/ruby.txt (354) covers 3 of them
cspell:dotnet/dotnet.txt (9824) covers 3 of them
cspell:node/node.txt (9611) covers 2 of them
cspell:bash/bash-words.txt (22) covers 1 of them

Consider adding them using:

      with:
        extra_dictionaries:
          cspell:cpp/cpp.txt
          cspell:html/html.txt
          cspell:filetypes/filetypes.txt
          cspell:css/css.txt
          cspell:python/python.txt
          cspell:django/django.txt
          cspell:golang/go.txt
          cspell:aws/aws.txt
          cspell:fullstack/fullstack.txt
          cspell:npm/npm.txt
          cspell:java/java.txt
          cspell:lua/lua.txt
          cspell:rust/rust.txt
          cspell:csharp/csharp.txt
          cspell:scala/scala.txt
          cspell:php/php.txt
          cspell:ruby/ruby.txt
          cspell:dotnet/dotnet.txt
          cspell:node/node.txt
          cspell:bash/bash-words.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the git@github.com:LeStarch/fprime-gds.git repository
on the update/fancy-tab branch:

(cd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"Emoji Linux MULTILINE Uint "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"activedescendant Addrs adrianheine autocapitalize autocompleter autocompletion autocorrect beforeinput beforeprint bitmask bparse brk btoa bugzilla changeset closebrackets cmp codemirror codepoint compat compositionend compositionstart compositionupdate contenteditable contextmenu coords crelt cx debounce Dedup deps deref DOMAt doy dragstart ecx ek elts emacs emoji eor expr fallthrough FIXME fx getdx getdy gmail grammer gx Haverbeke heightmap hift highlighter hightest higlighting idx instanceof invididual itis iz jj jkl keybindings keyboardselection keydown keymap keyup kh lezer lineboundary linewise linting linux marijnh matchbrackets mergeable mno mousedown mouseleave mousemove mouseup mozilla multiline NFKD NLR noncomplete npm nrt NSM offet onchange onclick onerror onkeydown onkeyup onmousedown onsubmit OOQO OPO OPOOOd OPPQ OSPR OSQO overapproximation overriden OVXOWXOXXOYXO Pfl placeholders pointerselection POOO Ppq PQQO pqr prebuilt Pz qa QPO QQO QVQPOOP QVQPOOPi QX rangeset rects regexp reindent reindentation relayout reparse respresents rollup rtl rv scroller selectionchange shadowroot sor specializers spellcheck SROr Stdio strikethrough strs stu subtag sucessfully tempdir textfield Theif tok tokenizer touchmove touchstart traveral TROSTYUZQSORVSQZUR TWQ ucd uint uncomment unneccesary unregistering Unrelatedly UPX viewports WDnr webpack xmlns XUWQ YZzrs ZP ZUWQ ZWJ "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
)

@lgtm-com
Copy link

lgtm-com bot commented Jul 31, 2021

This pull request introduces 3 alerts when merging 2b55277 into 0a374a4 - view on LGTM.com

new alerts:

  • 2 for Except block handles 'BaseException'
  • 1 for Unused variable, import, function or class

@github-actions
Copy link

github-actions bot commented Aug 1, 2021

@check-spelling-bot Report

🔴 Please review

Unrecognized words (14)
adrianheine
Codemirror
doy
gmail
Haverbeke
Lezer
Linting
marijnh
npm
rollup
Stdio
tempdir
Theif
webpack
Available dictionaries could cover words not in the dictionary

cspell:cpp/cpp.txt (104293) covers 128 of them
cspell:filetypes/filetypes.txt (337) covers 43 of them
cspell:html/html.txt (542) covers 39 of them
cspell:css/css.txt (993) covers 38 of them
cspell:python/python.txt (364) covers 30 of them
cspell:django/django.txt (2342) covers 22 of them
cspell:aws/aws.txt (1485) covers 18 of them
cspell:golang/go.txt (7745) covers 16 of them
cspell:fullstack/fullstack.txt (181) covers 14 of them
cspell:npm/npm.txt (671) covers 12 of them
cspell:java/java.txt (33524) covers 9 of them
cspell:lua/lua.txt (391) covers 6 of them
cspell:rust/rust.txt (112) covers 5 of them
cspell:csharp/csharp.txt (123) covers 5 of them
cspell:scala/scala.txt (2752) covers 4 of them
cspell:ruby/ruby.txt (354) covers 3 of them
cspell:php/php.txt (9785) covers 3 of them
cspell:dotnet/dotnet.txt (9824) covers 3 of them
cspell:node/node.txt (9611) covers 2 of them
cspell:bash/bash-words.txt (22) covers 1 of them

Consider adding them using:

      with:
        extra_dictionaries:
          cspell:cpp/cpp.txt
          cspell:filetypes/filetypes.txt
          cspell:html/html.txt
          cspell:css/css.txt
          cspell:python/python.txt
          cspell:django/django.txt
          cspell:aws/aws.txt
          cspell:golang/go.txt
          cspell:fullstack/fullstack.txt
          cspell:npm/npm.txt
          cspell:java/java.txt
          cspell:lua/lua.txt
          cspell:rust/rust.txt
          cspell:csharp/csharp.txt
          cspell:scala/scala.txt
          cspell:ruby/ruby.txt
          cspell:php/php.txt
          cspell:dotnet/dotnet.txt
          cspell:node/node.txt
          cspell:bash/bash-words.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
To accept these unrecognized words as correct, run the following commands

... in a clone of the git@github.com:LeStarch/fprime-gds.git repository
on the update/fancy-tab branch:

(cd $(git rev-parse --show-toplevel)
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"adrianheine Codemirror doy gmail Haverbeke Lezer Linting marijnh npm rollup Stdio tempdir Theif webpack "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
)

@lgtm-com
Copy link

lgtm-com bot commented Aug 1, 2021

This pull request introduces 3 alerts when merging b68fd58 into 0a374a4 - view on LGTM.com

new alerts:

  • 2 for Except block handles 'BaseException'
  • 1 for Unused variable, import, function or class

@LeStarch
Copy link
Collaborator Author

LeStarch commented Aug 1, 2021

Python alert is not new, just tabbed in one.

@metzdigital
Copy link

this is so cool!

@lgtm-com
Copy link

lgtm-com bot commented Aug 1, 2021

This pull request introduces 2 alerts when merging 536af64 into 0a374a4 - view on LGTM.com

new alerts:

  • 2 for Except block handles 'BaseException'

@metzdigital
Copy link

metzdigital commented Aug 3, 2021

@LeStarch I believe you said you were going to fix these, given I'm running an older version of python3:
image

Which I'm guessing is why I get this:
image

@LeStarch
Copy link
Collaborator Author

LeStarch commented Aug 3, 2021

@metzdigital should work on your revision now.

@lgtm-com
Copy link

lgtm-com bot commented Aug 3, 2021

This pull request introduces 2 alerts when merging 0181878 into 0a374a4 - view on LGTM.com

new alerts:

  • 2 for Except block handles 'BaseException'

@metzdigital
Copy link

  • Confirmed the python error has gone away and now get multiline error reporting.
  • Note bug found when dealing with what looks like the smart highlighting:
    image
  • Will still approve to get this merged but should be fixed at some point.

@metzdigital metzdigital self-requested a review August 3, 2021 21:54
metzdigital
metzdigital previously approved these changes Aug 3, 2021
Copy link

@metzdigital metzdigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@lgtm-com
Copy link

lgtm-com bot commented Aug 3, 2021

This pull request introduces 2 alerts when merging 155b861 into 4e54110 - view on LGTM.com

new alerts:

  • 2 for Except block handles 'BaseException'

@lgtm-com
Copy link

lgtm-com bot commented Aug 3, 2021

This pull request introduces 2 alerts when merging 1c33f6b into 4e54110 - view on LGTM.com

new alerts:

  • 2 for Except block handles 'BaseException'

Copy link

@metzdigital metzdigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@LeStarch LeStarch merged commit b7a4788 into nasa:devel Aug 3, 2021
@LeStarch
Copy link
Collaborator Author

LeStarch commented Aug 3, 2021

Merging this change. Lint warnings are not new (just moved slightly) and

@lgtm-com
Copy link

lgtm-com bot commented Aug 3, 2021

This pull request introduces 2 alerts when merging b46b626 into 9994195 - view on LGTM.com

new alerts:

  • 2 for Except block handles 'BaseException'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants