-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/enum representation types #155
Merged
LeStarch
merged 7 commits into
nasa:devel
from
JackNWhite:fix/enum_representation_types
Feb 16, 2024
Merged
Fix/enum representation types #155
LeStarch
merged 7 commits into
nasa:devel
from
JackNWhite:fix/enum_representation_types
Feb 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 11, 2023
LeStarch
reviewed
Dec 11, 2023
This looks good too. We'll need to fix the test. However, we'll need an alpha release of |
…e type with default value in dict.get()
This is approved once we get an alpha release of the fprime-tools fix. |
Closed And reopened to trick CI |
LeStarch
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
When loading enums, XML loader checks whether this field exists for the enum in question, and defaults to I32.
Rationale
Serialization/representation types are part of the F' and FPP specs, but are not, in fact, supported.
Accompanying PRs