Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/enum representation types #155

Merged
merged 7 commits into from
Feb 16, 2024

Conversation

JackNWhite
Copy link
Contributor

@JackNWhite JackNWhite commented Dec 11, 2023

Originating Project/Creator Jack White
Affected Component XML loader
Related Issue(s) nasa/fprime-tools/issues/17
Has Unit Tests (y/n) n

Change Description

When loading enums, XML loader checks whether this field exists for the enum in question, and defaults to I32.

Rationale

Serialization/representation types are part of the F' and FPP specs, but are not, in fact, supported.

Accompanying PRs

@LeStarch
Copy link
Collaborator

This looks good too. We'll need to fix the test. However, we'll need an alpha release of fprime-tools and to add that to the setup.py file as we've changed the underlying interface.

@LeStarch
Copy link
Collaborator

This is approved once we get an alpha release of the fprime-tools fix.

@LeStarch LeStarch closed this Feb 16, 2024
@LeStarch LeStarch reopened this Feb 16, 2024
@LeStarch
Copy link
Collaborator

Closed And reopened to trick CI

@LeStarch LeStarch merged commit 7f3bb47 into nasa:devel Feb 16, 2024
17 of 21 checks passed
@JackNWhite JackNWhite deleted the fix/enum_representation_types branch February 16, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants