-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EVR page freeze issue #6
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Misspellings found, please review:
To accept these changes, run the following commands from this repository on this branch
|
Misspellings found, please review:
To accept these changes, run the following commands from this repository on this branch
|
Misspellings found, please review:
To accept these changes, run the following commands from this repository on this branch
|
Misspellings found, please review:
To accept these changes, run the following commands from this repository on this branch
|
LeStarch
approved these changes
Jul 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The video really helped!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Current GDS Event page freezes when the number of EVRs in the event table reaches a certain size.
This issue makes the entire webpage irresponsive.
Rationale
The issue is DOM rendering is computationally expensive and having too many HTML elements in the DOM can effect browser's performance. To fix the issue this PR adds lazy loading of EVRs. Events are only added up to a certain number. After the maximum size user has to scroll down to the bottom of the page to load the next group of EVRs. Upon adding the new group the previous EVRs are removed from the DOM.
Testing/Review Recommendations
Manually tested and verified root cause of the slow down is the number of HTML elements and not memory issues.
GDS with issue
Manually verified GDS functionality after the fix. As shown in the video below the EVR table had ~28K EVRs and the page did not show any sign of slow down:
GDS EVR fixed
Functionalities:
First
button to move to the top of the list.Last
button to move to the bottom of the list.Last
button or scrolling down to the last element of the list.Future Work
NA