Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ogma-cli: Fix rendering of quotes in URLs in package description. Refs #72. #90

Merged
merged 2 commits into from
May 21, 2023

Conversation

ivanperez-keera
Copy link
Member

Fix rendering of quotes in URLs in package description, as prescribed in the solution proposed for #72.

…#72.

The description in the cabal file contains two entries with double quotes in
the tiles of links. Those double quotes are not displayed correctly on hackage:
instead of appearing as ", they are shown as ".

This commit moves the quotes outside the link text so that hackage will render
them without escaping them.
@ivanperez-keera
Copy link
Member Author

Change Manager: Verified that:

  • Solution is implemented:
    • The code proposed compiles passes the tests. Details:
      Docker image:

      FROM ubuntu:trusty
      
      RUN apt-get update
      
      RUN apt-get install --yes software-properties-common
      RUN add-apt-repository ppa:hvr/ghc
      RUN apt-get update
      
      RUN apt-get install --yes ghc-8.6.5 cabal-install-2.4
      RUN apt-get install --yes libz-dev
      
      ENV PATH=/opt/ghc/8.6.5/bin:/opt/cabal/2.4/bin:$PWD/.cabal-sandbox/bin:$PATH
      
      RUN cabal update
      RUN cabal v1-sandbox init
      RUN cabal v1-install alex happy
      RUN apt-get install --yes git
      
      # We install the application first and then test it, in case any tests need to
      # run the tool.
      CMD git clone $REPO && \
          cd $NAME && \
          git checkout $COMMIT && \
          cd .. && \
          cabal v1-install $NAME/$PAT**/ --enable-tests && \
          cabal v1-install $NAME/$PAT**/ --enable-tests --run-tests -j1

      Command:

      $ docker run -e "REPO=https://github.com/NASA/ogma" -e "NAME=ogma" -e PAT="ogma-" -e "COMMIT=194710ef46b5fbe176e23ea9397409f007e0b987" -it ogma-test
    • The solution proposed fixes the issues described. Details:
      The issue is with the documentation and cannot be replicated locally with haddock. Verification is performed by visual inspection, by uploading a package candidate to hackage and checking that the solution makes the quotes be rendered correctly.

  • Implementation is documented. Details:
    The change is to the documentation. No further changes to documentation are needed.
  • Change history is clear.
  • Commit messages are clear.
  • Changelogs are updated.
  • Examples are updated. Details:
    No examples affected.
  • Required version bumps are evaluated. Details:
    No bump needed (change to documentation).

@ivanperez-keera ivanperez-keera merged commit 5008830 into develop May 21, 2023
@ivanperez-keera ivanperez-keera deleted the develop-escaped-quotes branch May 21, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant