Open e2e Testing Initiative

[unlikelyzero]

Follow this Discussion to learn about the Open e2e Testing Initiative with Open MCT!

Goals

1. Increase our e2e testing coverage
2. Provide an opportunity for the testing community to directly contribute to NASA Open Source
3. Learn from folks who demonstrate some new approaches to old testing challenges with Playwright.
4. Ensure that Open MCT testing is accessible to everyone

How to contribute

We will be open sourcing and outlining new e2e tests that will follow our existing contributing guidelines.

Please make a comment in this Github Discussion if you are interested in participating and include if you've already submitted your CLA!

Getting started with Playwright and Open MCT

Getting started with Playwright and Open MCT

Don't worry if you haven't submitted your CLA, you can get started without it. It'll only prevent the final merge. You should still submit this ASAP as it can take up to 3 weeks.

What to contribute

After finishing How to contribute above, there are two ways of contributing tests:

Help Wanted tickets in Improve Test Coverage

1. Complete the 'How to Contribute' section above
2. Check the list of help_wanted issues on the Improve Test Coverage Project.
3. If you find one that you want to work on, please assign it to yourself and update your Discussion comment thread that you've taken it on!
4. If you have any additional questions about these, please ask within a new thread on this Github Discussion.

Test TODOs within the codebase (aka test.fixme())

1. Complete the 'How to Contribute' section above
2. Check our codebase for tests labeled with the test.fixme().
3. If you find one, update your Github Discussion and we'll make a new Issue to track the work.
   The test.fixme() lines are found within the e2e/tests/**.e2e.spec.js files and look like this:

Something else?

If you have an idea about what you'd want to contribute, but don't see it list, please make a thread on this discussion!

Current Contributors

@gholin - CLA Approved - Tests Implemented
@afahey87 - CLA Approved - Tests Implemented
@dimitriharding - CLA Approved - Tests Implemented
@loftwah - CLA Approved - Tests Implemented
@MarkCodering - CLA ?

[unlikelyzero]

@afahey87 actually... I think that one may have been addressed as a part of #5128

Hmmmm

[afahey87]

No problem. Ill take a look again later tonight.

[afahey87]

@unlikelyzero How about this one? https://github.com/nasa/openmct/blob/ab4d0dd37f2269de84b6f8f4b6be0f0874018f57/e2e/tests/plugins/imagery/exampleImagery.e2e.spec.js

[unlikelyzero]

@afahey87 that would be incredible :)

[afahey87]

Challenge accepted! 🤓

[dimitriharding]

Hi John, I am very interested in contributing to this project that you mentioned during your keynote at StarEast.

If you could let me know where I can start, that would be great!

[unlikelyzero]

@dimitriharding we did not receive your CLA. Can you tell us which address you sent it to?

[jvigliotta]

@dimitriharding I'll look into the status of your CLA, sometimes it can take a bit. I will keep you posted. Thanks for your patience!

[dimitriharding]

@jvigliotta / @unlikelyzero My CLA status should be good now, could we check on this?

[unlikelyzero]

@dimitriharding you are good to go!

[unlikelyzero]

@dimitriharding let me know how exportAsJson goes :)

[unlikelyzero]

@gholin you are the first! #5128

[MarkCodering]

@unlikelyzero It is Mark here. I sent my signed CLA based on guidelines from #3821 yesterday from the email mark.chen.sstm@gmail.com. Could you confirm the submission? Also, I am interested in this initiative, and could you check the CLA status so I can add my contribution to the codebase. Thanks for your help.

[jvigliotta]

@MarkCodering Hi Mark! It usually takes about a week turn around time for CLA's. Sometimes longer, but usually around a week at minimum. I'll keep an eye out and once we have it confirmed, we'll let you know!

[MarkCodering]

@jvigliotta Understood. But, I haven't received any updates from NASA yet. Do I need to submit any supplement material?

[MarkCodering]

Hi, @jvigliotta. A quick follow-up: Do we have any updates from NASA regarding CLA sign-up?

[jvigliotta]

@MarkCodering I am very sorry for dropping this, we do have your CLA on file.

[eddiejaoude]

Sounds interesting John! Debbie directed me here

[unlikelyzero]

@eddiejaoude that's great! Would you like to contribute?

[loftwah]

@eddiejaoude gave me the tip too :). I would love to contribute further.

[eddiejaoude]

Yes @unlikelyzero I would like to contribute and I am sure my community would too!

[loftwah]

I filled out the wrong CLA, it has been corrected now. Here is the correct one for individual contributors.

[marcel-veselka]

Hi @unlikelyzero I am interested.

I read all about how to contribute and checked help wanted but didn't too much info on how and where I could start.
Any advice on how to start? ... or at least start with learning before I will be ready to contribute?

I didn't submit CLA yet.

[TejAllam]

Hello John! I came across your talk on Playwright and wanted to contribute to the project.
I have some experience with Playwright as part of my work. Would love to contribute to Open source projects.
Please advice.

[unlikelyzero]

@TejAllam welcome aboard! If you haven't already, please submit the CLA. #3821

We recommend that everyone run through the getting started documentation to get familiar with playwright, then Open MCT and playwright: https://github.com/nasa/openmct/tree/master/e2e#getting-started

Once you've done that, would you mind taking a look at #3213 (comment) ? If you have an additional questions, we can follow up on that ticket!

[TejAllam]

Sure @unlikelyzero . Will do right away. Thanks!

[sabrinapowell]

Hi @unlikelyzero, I was recently introduced to the project by one of the contributors (Dimitri Harding). I'm really interested in contributing and would like some info on getting started. Please advice!

[unlikelyzero]

@sabrinapowell would you mind taking a stab at one of these

openmct/e2e/tests/functional/plugins/timeConductor/timeConductor.e2e.spec.js

Lines 151 to 169 in e4a3653

	test.fixme('time conductor history in fixed time mode will track changing start and end times', async ({ page }) => {
	// change start time, verify it's tracked in history
	// change end time, verify it's tracked in history
	});
	test.fixme('time conductor history in realtime mode will track changing start and end times', async ({ page }) => {
	// change start offset, verify it's tracked in history
	// change end offset, verify it's tracked in history
	});
	test.fixme('time conductor history allows you to set a historical timeframe', async ({ page }) => {
	// make sure there are historical history options
	// select an option and make sure the time conductor start and end bounds are updated correctly
	});
	test.fixme('time conductor history allows you to set a realtime offsets', async ({ page }) => {
	// make sure there are realtime history options
	// select an option and verify the offsets are updated correctly
	});

[sabrinapowell]

Sure! I'll take the first one

[sabrinapowell]

@unlikelyzero I have opened an issue here and a Draft PR here. Please take a look at the PR when you get a chance. I have noted a bug I am seeing on it.

[sabrinapowell]

@unlikelyzero I'm interested in picking up another area. Please let me know what's available

[ozyx]

Hi @sabrinapowell ! Thanks for your patience. A great place to pick up would be filling out some test stubs in our notebook or our import and export e2e tests.

Let us know if you plan on picking any of these up and if we can provide any guidance to help you get started! Thanks again!

[saram7619]

Hi, I reviewed the docs, emailed the signed CLA two weeks ago and I have installed the project locally. I am wanting to contribute.

[ozyx]

@saram7619 It has been approved! Thanks for your patience. :)

[saram7619]

@ozyx Thanks for accepting my CLA, can’t wait to start contributing.

[ozyx]

Hi @saram7619 !

A great place to start would be with filling out some test stubs in our notebook or our import and export e2e tests.

Let us know if you plan on picking any of these up and if we can provide any guidance to help you get started! Thanks!

[saram7619]

I’ll take a look tomorrow morning. Thanks for the opportunity to contribute.

[saram7619]

Hi @ozyx I'm planning to pick the test stubs in your notebook. Going to get started now.

[saram7619]

Hi @ozyx, I will take the ones in the notebook. Is it one test.fixme at a time?

[ozyx]

@saram7619 awesome! Please feel free to tackle as many or as few as you like in a single PR. Smaller PRs are generally quicker to review, however. Be sure to check out our e2e testing README for some tips and feel free to reach out with any other questions you may have. Thanks for taking this on!