Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Time Conductor] In fixed time mode, dismissing bounds changes actually submits them #7791

Closed
2 of 7 tasks
ozyx opened this issue Jul 25, 2024 · 2 comments · Fixed by #7792
Closed
2 of 7 tasks

[Time Conductor] In fixed time mode, dismissing bounds changes actually submits them #7791

ozyx opened this issue Jul 25, 2024 · 2 comments · Fixed by #7792
Assignees
@ozyx
Labels
type:bug verified Tested or intentionally closed

Comments

@ozyx
Copy link
Contributor

ozyx commented Jul 25, 2024

Summary

When making changes to time conductor bounds in fixed mode, dismissing the changes via the 'X' button will submit them anyway.

Discovered due to failing tests in openmct-yamcs

Expected vs Current Behavior

Clicking 'Dismiss' should not submit any changes

Steps to Reproduce

  1. Switch to fixed time mode in the global time conductor
  2. Change the start year to something else (e.g. 2024 -> 2023)
  3. Dismiss the changes by clicking the 'X'
  4. Check the time conductor and see that the change has actually been submitted

Environment

  • Open MCT Version: 4.0.0-next
  • Deployment Type: local, openmct-yamcs
  • OS: any
  • Browser: chrome

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

Screen.Recording.2024-07-25.at.9.35.28.AM.mov
@ozyx ozyx added the type:bug label Jul 25, 2024
@ozyx ozyx self-assigned this Jul 25, 2024
ozyx added a commit that referenced this issue Jul 25, 2024
@ozyx
fix(#7791): tc form shouldn't submit bounds changes on dismiss
14f505e
@ozyx ozyx mentioned this issue Jul 25, 2024
Merged
14 tasks
ozyx added a commit that referenced this issue Jul 25, 2024
@ozyx
fix(#7791): actually fix the problem. Also, add a test.
54e729c
@ozyx
Copy link
Contributor Author

ozyx commented Jul 25, 2024

Testing Instructions

  • Follow steps to reproduce and verify that the time conductor does not change bounds if changes are dismissed

ozyx added a commit that referenced this issue Jul 25, 2024
@ozyx
fix(#7791): tc form shouldn't submit bounds changes on dismiss (#7792)
e3fcbe1 
* fix(#7791): tc form shouldn't submit bounds changes on dismiss

* test(e2e): add tests for validating time conductor popup

- update appAction for setting time conductor in fixed mode
- add a11y to time conductor in fixed mode
- update tests using `setTimeConductorBounds`

* fix(#7791): actually fix the problem. Also, add a test.

* test: add annotation to regression test

* docs: comments

* test: fix the reset image button flake ONCE AND FOR ALL

- wait for the rightmost image thumbnail to be in the viewport :D

* test: add tests for `setTimeConductorMode` and `setTimeConductorBounds`
@akhenry akhenry added this to the Build 9 RC11 milestone Oct 2, 2024
@jvigliotta
Copy link
Contributor

Verified Fixed - Testathon 10/2/24

@akhenry akhenry added the verified Tested or intentionally closed label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ozyx ozyx

Labels
type:bug verified Tested or intentionally closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#7791): tc form shouldn't submit bounds changes on dismiss nasa/openmct
3 participants
@akhenry @ozyx @jvigliotta