-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle aborted get requests and null domain objects when using ObjectAPI #7276
Handle aborted get requests and null domain objects when using ObjectAPI #7276
Conversation
Current Playwright Test Results Summary✅ 15 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 12/05/2023 05:43:28pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: f9737a5 Started: 12/05/2023 05:37:58pm UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Display Layout When multiple plots are contained in a layout, we only ask for annotations once @couchdb
Retry 1 • Initial Attempt |
0% (0)0 / 46 runsfailed over last 7 days |
15.22% (7)7 / 46 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 164 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 12/05/2023 05:43:28pm UTC)
⚠️ Flakes
📄 functional/plugins/tabs/tabs.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Tabs View Renders tabbed elements
Retry 1 • Initial Attempt |
0% (0)0 / 56 runsfailed over last 7 days |
7.14% (4)4 / 56 runsflaked over last 7 days |
📄 functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Telemetry Table unpauses and filters data when paused by button and user changes bounds
Retry 1 • Initial Attempt |
0% (0)0 / 55 runsfailed over last 7 days |
27.27% (15)15 / 55 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
2.53% (2)2 / 79 runsfailed over last 7 days |
58.23% (46)46 / 79 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 57 runsfailed over last 7 days |
33.33% (19)19 / 57 runsflaked over last 7 days |
📄 functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1 • Initial Attempt |
1.72% (1)1 / 58 runfailed over last 7 days |
62.07% (36)36 / 58 runsflaked over last 7 days |
Network throttled to fast 3G and search debounce set to 10ms. before.movAfter: after.mov |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7276 +/- ##
==========================================
- Coverage 55.98% 55.88% -0.10%
==========================================
Files 655 655
Lines 26286 26290 +4
Branches 2540 2540
==========================================
- Hits 14716 14693 -23
- Misses 10857 10884 +27
Partials 713 713
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all LGTM! Just a note to remove one commented line
@scottbell need to cherry pick this onto |
…API (#7276) * handle null domain objects * add some test coverage for aborting search results * to make test independent
|
Closes #7275
Describe your changes:
All Submissions:
Author Checklist
Reviewer Checklist