Automatically check additional views for memory leaks on navigation #7300
Conversation
scottbell
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Current Playwright Test Results Summary✅ 15 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 12/15/2023 09:00:01am UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: aeac908 Started: 12/15/2023 08:58:19am UTC Current Playwright Test Results Summary✅ 165 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 12/15/2023 09:00:01am UTC)
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt |
0% (0)0 / 57 runsfailed over last 7 days |
28.07% (16)16 / 57 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 58 runsfailed over last 7 days |
44.83% (26)26 / 58 runsflaked over last 7 days |
📄 functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1 • Initial Attempt |
1.79% (1)1 / 56 runfailed over last 7 days |
50% (28)28 / 56 runsflaked over last 7 days |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7300 +/- ##
==========================================
- Coverage 55.87% 55.49% -0.38%
==========================================
Files 655 655
Lines 26324 26327 +3
Branches 2544 2544
==========================================
- Hits 14708 14611 -97
- Misses 10898 11019 +121
+ Partials 718 697 -21
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…for-memory-leaks-on-navigation
scottbell
added
pr:e2e:couchdb
| @@ -26,7 +26,7 @@ | |||
| <li> | |||
| <series-options | |||
| v-for="series in plotSeries" | |||
| :key="series.key" | |||
| :key="series.keyString" | |||
There was a problem hiding this comment.
this was your catch!
|
@scottbell you have a failure on restricted notebook |
Lemme make sure it's not due to my changes. |
It's a known flake. on the perf test, I just re-ran the plot view test 5x and no flakes on my end (in ci env), so it might be a very rare flake? |
…for-memory-leaks-on-navigation
scottbell
deleted the
6734-automatically-check-additional-views-for-memory-leaks-on-navigation
branch
Closes #6734
Describe your changes:
All Submissions:
Author Checklist
Reviewer Checklist