Fix constrast for accessibility #7315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Playwright Test Results Summary✅ 161 Passing - ❌ 2 Failing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 12/21/2023 03:53:51am UTC) ❌ Failures📄 functional/plugins/plot/logPlot.e2e.spec.js • 1 FailureTest Case Results
📄 functional/plugins/plot/autoscale.e2e.spec.js • 1 FailureTest Case Results
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1 • Initial Attempt |
0% (0)0 / 87 runsfailed over last 7 days |
28.74% (25)25 / 87 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 85 runsfailed over last 7 days |
48.24% (41)41 / 85 runsflaked over last 7 days |
|
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
2.35% (2)2 / 85 runsfailed over last 7 days |
38.82% (33)33 / 85 runsflaked over last 7 days |
📄 functional/plugins/conditionSet/conditionSet.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Basic Condition Set Use ConditionSet has correct outputs when telemetry is and is not available
Retry 1 • Initial Attempt |
0% (0)0 / 96 runsfailed over last 7 days |
2.08% (2)2 / 96 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
2.94% (3)3 / 102 runsfailed over last 7 days |
56.86% (58)58 / 102 runsflaked over last 7 days |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7315 +/- ##
==========================================
- Coverage 55.62% 55.58% -0.05%
==========================================
Files 668 668
Lines 26704 26704
Branches 2585 2585
==========================================
- Hits 14855 14844 -11
- Misses 11136 11148 +12
+ Partials 713 712 -1
*This pull request uses carry forward flags. Click here to find out more.
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
e2e/avpFixtures.js
Outdated
| @@ -60,7 +60,7 @@ exports.scanForA11yViolations = async function (page, testCaseName, options = {} | |||
| const builder = new AxeBuilder({ page }); | |||
| builder.withTags(['wcag2aa']); | |||
| // https://github.com/dequelabs/axe-core/blob/develop/doc/rule-descriptions.md | |||
| builder.disableRules(['color-contrast']); | |||
| //builder.disableRules(['color-contrast']); | |||
There was a problem hiding this comment.
this will eventually be deleted
- CSS normalized across all themes via Google Sheet at https://docs.google.com/spreadsheets/d/1SEEtuNSq6I7gvVHKpHW8_fp8Ltc-HOAWxrSAkUzS6Kw/edit?usp=sharing
|
@charlesh88 the following items are not actually marked as disabled in the DOM:
|
charlesh88
changed the title
|
Not needed for Build 9, but deferring this will incur risk for future merges. |
|
@unlikelyzero What do we need to do to get this merged? |
This was referenced Jan 24, 2024
unlikelyzero
approved these changes
Jan 30, 2024
unlikelyzero
added
pr:e2e:couchdb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7304
Describe your changes:
@unlikelyzero to investigate:
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist