Skip some tests, fix a mislabeled test, and add default condition for tabs #7422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unlikelyzero
added
type:maintenance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7422 +/- ##
==========================================
- Coverage 55.95% 55.89% -0.06%
==========================================
Files 662 662
Lines 26432 26432
Branches 2574 2574
==========================================
- Hits 14790 14775 -15
- Misses 10928 10943 +15
Partials 714 714
*This pull request uses carry forward flags. Click here to find out more. see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ozyx
approved these changes
Jan 28, 2024
|
|
||
| page.goto(tabsView.url); |
There was a problem hiding this comment.
ahh nice catch. hate when this happens
Comment on lines
+107
to
+115
| test('Eager Load Tabs is the default', async ({ page }) => { | ||
| await page.goto(tabsView.url); | ||
|
|
||
| await page.getByLabel('Edit Object').click(); | ||
| await page.getByLabel('More actions').click(); | ||
| await page.getByLabel('Edit Properties...').click(); | ||
| await expect(await page.getByLabel('Eager Load Tabs')).toHaveValue('true'); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
this test is a thing of beauty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #7421
Describe your changes:
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist