fix(#7215)[Fault Management]: Fix shelving and acknowledging faults with single and bulk actions #7559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…only apply to selected fault
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7559 +/- ##
==========================================
- Coverage 55.58% 55.30% -0.28%
==========================================
Files 673 672 -1
Lines 26994 27003 +9
Branches 2623 2624 +1
==========================================
- Hits 15004 14934 -70
- Misses 11271 11348 +77
- Partials 719 721 +2
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
unlikelyzero
reviewed
Mar 6, 2024
| .getByLabel('Select fault') | ||
| .nth(rowNumber - 1) | ||
| .check({ | ||
| // Need force here because checkbox state is changed by an event emitted by the checkbox |
There was a problem hiding this comment.
yep but i'd rather this than have to restructure all of fault management
unlikelyzero
reviewed
Mar 6, 2024
| await utils.clearSearch(page); | ||
| faultResultCount = await utils.getFaultResultCount(page); | ||
| expect.soft(faultResultCount).toEqual(5); | ||
| await clearSearch(page); |
unlikelyzero
reviewed
Mar 6, 2024
|
|
||
| // search triggerTime | ||
| await utils.enterSearchTerm(page, faultFiveTriggerTime); | ||
| await enterSearchTerm(page, faultFiveTriggerTime); |
unlikelyzero
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7215
Describe your changes:
shelvedFaultsa computed property to fix Vue reactivityFaultManagementListViewintoFaultManagementViewto simplifyAll Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist