-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For an existing View in a Preview, ensure we pull the same ActionCollection
#7632
For an existing View in a Preview, ensure we pull the same ActionCollection
#7632
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7632 +/- ##
==========================================
- Coverage 56.32% 55.96% -0.36%
==========================================
Files 672 672
Lines 27128 27119 -9
Branches 2635 2632 -3
==========================================
- Hits 15279 15178 -101
- Misses 11522 11612 +90
- Partials 327 329 +2
... and 15 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, just a couple suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…lable-in-preview-mode
Closes #7158
Describe your changes:
In Preview mode, we weren't pulling the same cached copy of the
ActionsCollection
, and thus weren't picking up any state changes from the View.All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist