RTC-S1 CalVal v4.1 PGE Integration #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimHofman
reviewed
Aug 7, 2023
src/opera/pge/rtc_s1/rtc_s1_pge.py
Outdated
| """ | ||
| Returns the base file name to use for RTC products produced by this PGE. | ||
|
|
||
| The base filename for the RTC PGE consists of: | ||
|
|
||
| <Core filename>_<BURST ID>_<ACQUISITION TIME>_<PRODUCTION TIME>_<SENSOR>_<SPACING>_<PRODUCT VERSION> | ||
|
|
||
| Where <Core filename> is returned by RtcS1PostProcessorMixin._core_filename(). | ||
| Where <Core filename> is returned by RtcS1PostProcessorMixin._core_filename() | ||
| if static_layer_product is False, otherwise it the value returned by |
JimHofman
reviewed
Aug 7, 2023
| RtcS1PostProcessorMixin._core_static_filename() | ||
|
|
||
| If static_layer_product is True, <ACQUISITION TIME> will correspond | ||
| to the configured data validity start time (as defined in the RunConfig). | ||
|
|
||
| Parameters | ||
| ---------- | ||
| inter_filename : str |
There was a problem hiding this comment.
I know this is not part of the changes, but to me this description is not very clear.
JimHofman
reviewed
Aug 7, 2023
src/opera/pge/rtc_s1/rtc_s1_pge.py
Outdated
| Where <RTC filename> is returned by RtcS1PostProcessorMixin._rtc_filename(), | ||
| and <Static layer name> is the identifier for the specific static layer | ||
| Where <RTC static filename> is returned by RtcS1PostProcessorMixin._rtc_filename() | ||
| with static_layer_product set ot True. |
JimHofman
reviewed
Aug 7, 2023
|
|
||
| Parameters | ||
| ---------- | ||
| inter_filename : str |
There was a problem hiding this comment.
related to comment above
JimHofman
approved these changes
Aug 7, 2023
| @@ -57,14 +63,31 @@ runconfig: | |||
| # `RTC-S1_069-147170-IW1_S1B` for the burst t069-147170-IW1; and it | |||
| # will become `RTC-S1_S1B` for the mosaic product. | |||
| # | |||
| # If the field `product_id`` is left empty, the prefix | |||
| # "OPERA_L2_RTC-S1_{burst_id}" will be used instead. | |||
| # For RTC-S1 products, if the field `product_id`` is left empty, | |||
| <gco:CharacterString>InputBackscatterNormalizationConvention</gco:CharacterString> | ||
| </eos:name> | ||
| <eos:description> | ||
| <gco:CharacterString>Normalization convention for input backscatter</gco:CharacterString> |
There was a problem hiding this comment.
The string here doesn't follow the convention. I would expect "Input Backscatter Normalization Convention"
david-inglish
approved these changes
Aug 7, 2023
added 7 commits
August 8, 2023 07:21
…Hmmss portion is not needed
collinss-jpl
force-pushed
the
332_rtc_s1_v4.1_integration
branch
from
5043196 to
d508a35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Affected Issues
Testing