#348 add disp_s1 iso-metadata #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/opera/pge/disp_s1/disp_s1_pge.py
Outdated
| for use with the ISO metadata Jinja2 template. | ||
|
|
||
| """ | ||
| # Find a single representative output DSWx-HLS product, they should all |
src/opera/pge/disp_s1/disp_s1_pge.py
Outdated
| 'ISO_OPERA_ProducerGranuleId': self._core_filename(), | ||
| 'MetadataProviderAction': "creation", | ||
| 'GranuleFilename': self._core_filename(), | ||
| 'ISO_OPERA_ProjectKeywords': ['OPERA', 'JPL', 'DSWx', 'Dynamic', 'Surface', 'Water', 'Extent'], |
There was a problem hiding this comment.
Should these particular keywords be related to surface displacement?
collinss-jpl
requested changes
Sep 18, 2023
requirements.txt
Outdated
There was a problem hiding this comment.
Was this intended for inclusion? I want to keep the versions un-pinned in this file since we install into an existing environment within the SAS container.
| @@ -36,7 +39,7 @@ class DispS1PreProcessorMixin(PreProcessorMixin): | |||
| def run_preprocessor(self, **kwargs): | |||
| """ | |||
| Executes the pre-processing steps for DISP-S1 PGE initialization. | |||
| The DswxS1PreProcessorMixin version of this class performs all actions | |||
| The DispS1PreProcessorMixin version of this class performs all actions | |||
| of the base PreProcessorMixin class, and adds an input validation step for | |||
| the inputs defined within the RunConfig (TODO). | |||
There was a problem hiding this comment.
The (TODO) here can be removed
|
|
||
| pge = DispS1Executor(pge_name="DispS1PgeTest", runconfig_path=runconfig_path) | ||
| pge.run() | ||
|
|
There was a problem hiding this comment.
This unit test should also testing the following:
- That the .iso.xml file was written to disk with the expected filename
- That the contents of the iso.xml does not contain the phrase "!Not found!"
See the example here for DSWx-HLS: https://github.com/nasa/opera-sds-pge/blob/main/src/opera/test/pge/dswx_hls/test_dswx_hls_pge.py#L132-L141
collinss-jpl
force-pushed
the
348_disp_s1_iso_xml
branch
from
47057d0 to
93d3be1
Compare
collinss-jpl
approved these changes
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing