QA Application Support #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimHofman
reviewed
Feb 3, 2022
| If the QA executable exists within the current environment, but is not | ||
| set with execute permissions for the current process. | ||
|
|
||
| """ |
There was a problem hiding this comment.
Very clear docstring with just enough detail
| """ | ||
| command_line = [] | ||
|
|
||
| if executable_path := shutil.which(qa_program_path): |
There was a problem hiding this comment.
I looked at PEP 572 - Assignment Expression and under Syntax and semantics I found an example of a regex that is pretty similar to what is here.
I think it's a little clearer to say:
if (executable_path := shutil.which(qa_program_path)) is not None:
| f"but does not have execute permissions.") | ||
| # Otherwise, qa_program_path might be a python module path | ||
| else: | ||
| command_line = ['python3', '-m', qa_program_path] |
There was a problem hiding this comment.
I like the comments here.
added 2 commits
February 4, 2022 11:05
QA application execution is performed similarly to the main SAS execution, but is optional based on how the RunConfig is defined
collinss-jpl
force-pushed
the
44_qa_application_support
branch
from
4190588 to
81cc242
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the base PGE functionality to support execution of an optional Quality Assurance (QA) application after the primary SAS executable has completed. Execution occurs similarly to SAS execution, but is optional based on a setting within the RunConfig.