-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #85 update ISO template top-level to match SWOT #98
Issue #85 update ISO template top-level to match SWOT #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@david-inglish Changes to the template look great! Once the workarounds to dswx_pge.py
are pruned from this branch, it should be good to merge.
<gmd:CI_ResponsibleParty> | ||
<gmd:organisationName> | ||
<gco:CharacterString>Jet Propulsion Laboratory</gco:CharacterString> | ||
<gco:CharacterString>Jet Propulsion Repository</gco:CharacterString> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious what motivated this change, is there a JPR somewhere out there I've never heard of?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the display of the file differences is misleading here; the tool is trying to make associations where there are none.
I only changed the first "gmd:DS_Series" element to be "gmi:MI_Metadata", and then removed these 3 levels of XML elements to match the proposed output:
<gmd:composedOf>
<gmd:DS_DataSet>
<gmd:has>
<gmi:MI_Metadata>
</gmi:MI_Metadata>
</gmd:has>
</gmd:DS_DataSet>
</gmd:composedOf>
All of the lines between these removed fields was shifted left to fix indentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 34 in red at this location (old content) corresponds to line 30 in green (new content) if you scroll back up. Only the indent has changed.
</gmd:code> | ||
<gmd:codeSpace> | ||
<gco:CharacterString>gov.nasa.esdis.umm.otherid</gco:CharacterString> | ||
<gco:CharacterString>gov.nasa.esdis.umm.pgeversionclass</gco:CharacterString> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
These changes address Issue 85 for the top-level XML entries only: #85
The time range change mentioned in the email will be made as part of another TBD issue.