Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UT stub library missing "shell" API #1120

Closed
jphickey opened this issue Jul 29, 2021 · 0 comments · Fixed by #1121 or #1126
Closed

UT stub library missing "shell" API #1120

jphickey opened this issue Jul 29, 2021 · 0 comments · Fixed by #1121 or #1126
Labels
bug unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone

Comments

@jphickey
Copy link
Contributor

jphickey commented Jul 29, 2021

Describe the bug
The osapi-shell-stubs.c file was not included in the ut_osapi_stubs library, and hence apps needing to test shell functions will get a linker error due to this missing function.

To Reproduce
Attempt to build the unit test for an app that calls OS_ShellOutputToFile API. Link fails with the missing symbol.

Expected behavior
Build should succeed.

Code snips
List is here. The "shell" stub file is there (generated from header) but was missed/omitted from the library somehow.

add_library(ut_osapi_stubs STATIC
utstub-helpers.c
osapi-binsem-stubs.c
osapi-binsem-handlers.c
osapi-clock-stubs.c
osapi-clock-handlers.c
osapi-common-stubs.c
osapi-countsem-stubs.c
osapi-countsem-handlers.c
osapi-dir-stubs.c
osapi-dir-handlers.c
osapi-error-stubs.c
osapi-error-handlers.c
osapi-file-stubs.c
osapi-file-handlers.c
osapi-filesys-stubs.c
osapi-filesys-handlers.c
osapi-heap-stubs.c
osapi-heap-handlers.c
osapi-idmap-stubs.c
osapi-idmap-handlers.c
osapi-module-stubs.c
osapi-module-handlers.c
osapi-mutex-stubs.c
osapi-mutex-handlers.c
osapi-network-stubs.c
osapi-network-handlers.c
osapi-printf-stubs.c
osapi-printf-handlers.c
osapi-queue-stubs.c
osapi-queue-handlers.c
osapi-select-stubs.c
osapi-sockets-stubs.c
osapi-sockets-handlers.c
osapi-task-stubs.c
osapi-task-handlers.c
osapi-timer-stubs.c
osapi-timer-handlers.c
osapi-timebase-stubs.c
osapi-timebase-handlers.c
osapi-version-stubs.c
osapi-version-handlers.c
)

Reporter Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey added the bug label Jul 29, 2021
jphickey added a commit to jphickey/osal that referenced this issue Jul 29, 2021
@skliper skliper added this to the 6.0.0 milestone Jul 29, 2021
@skliper skliper added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label Jul 29, 2021
astrogeco added a commit that referenced this issue Aug 4, 2021
Fix #1120, add osapi-shell-stubs.c to OSAL stub library
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
Fix nasa#986, Remove unnecessary CFE_MSG_Init in TBL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
2 participants