Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrub for mismatched function prototype/implementation parameter names #1353

Closed
2 tasks done
thnkslprpt opened this issue Jan 22, 2023 · 0 comments · Fixed by #1354
Closed
2 tasks done

Scrub for mismatched function prototype/implementation parameter names #1353

thnkslprpt opened this issue Jan 22, 2023 · 0 comments · Fixed by #1354
Labels
enhancement

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
Noticed a couple of mismatched parameter names between function prototypes and their implementations. A quick scrub of OSAL turned up 13 cases in total.

Expected behavior
While not a risk to behavior, these mismatched parameter names may cause compiler errors in the future on some systems, and can be confusing for maintenance and application programming.

Code snips
Cases identified:
image

Reporter Info
Avi Weiss @thnkslprpt
thnkslprpt added a commit to thnkslprpt/osal that referenced this issue Jan 23, 2023
@thnkslprpt
Fix nasa#1353, Align mismatched function prototype/implementation par…
c0c8b3c 
…ameter names
@thnkslprpt thnkslprpt mentioned this issue Jan 23, 2023
Merged
2 tasks
thnkslprpt added a commit to thnkslprpt/osal that referenced this issue Feb 24, 2023
@thnkslprpt
Fix nasa#1353, Align mismatched function prototype/implementation par…
463ecd6 
…ameter names
thnkslprpt added a commit to thnkslprpt/osal that referenced this issue Feb 24, 2023
@thnkslprpt
Fix nasa#1353, Align mismatched function prototype/implementation par…
5f664fe 
…ameter names
dzbaker added a commit that referenced this issue Feb 23, 2024
@dzbaker
Merge pull request #1354 from thnkslprpt:fix-1353-mismatched-function…
e7add95 
…-parameter-names

Fix #1353, Align mismatched function prototype/implem. parameter names
@dzbaker dzbaker mentioned this issue Feb 23, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1353, Align mismatched function prototype/implem. parameter names thnkslprpt/osal
2 participants
@thnkslprpt @chillfig