Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper Null termination #805

Closed
skliper opened this issue Feb 11, 2021 · 1 comment · Fixed by #807 or #774
Closed

Improper Null termination #805

skliper opened this issue Feb 11, 2021 · 1 comment · Fixed by #807 or #774
Assignees
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Feb 11, 2021

Is your feature request related to a problem? Please describe.
A few cases of possible missing termination:

strncpy(module->file_name, filename, OS_MAX_PATH_LEN);

strncpy(*err_name, Error->Name, OS_ERROR_NAME_LENGTH - 1);

Describe the solution you'd like
Terminate.

Describe alternatives you've considered
None

Additional context
Secuity analysis warning

Requester Info
Jacob Hageman - NASA/GSFC

@skliper skliper added the bug label Feb 11, 2021
@skliper skliper added this to the 6.0.0 milestone Feb 11, 2021
@skliper skliper self-assigned this Feb 11, 2021
@skliper
Copy link
Contributor Author

skliper commented Feb 11, 2021

Note bug not confirmed, may be checked earlier but shouldn't be depended on.

skliper added a commit to skliper/osal that referenced this issue Feb 11, 2021
skliper added a commit to skliper/osal that referenced this issue Feb 11, 2021
skliper added a commit to skliper/osal that referenced this issue Feb 11, 2021
skliper added a commit to skliper/osal that referenced this issue Feb 12, 2021
astrogeco added a commit that referenced this issue Feb 12, 2021
Fix #805, Null terminate when using strncpy
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
Revert "Fix nasa#778, add cfe assert and example lib"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants