Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent OS_MAX_MODULE limit/documentation #882

Closed
skliper opened this issue Mar 11, 2021 · 0 comments · Fixed by #905 or #917
Closed

Inconsistent OS_MAX_MODULE limit/documentation #882

skliper opened this issue Mar 11, 2021 · 0 comments · Fixed by #905 or #917
Assignees
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Mar 11, 2021

Is your feature request related to a problem? Please describe.
Comments don't match check:

/*
* Sanity checks on the user-supplied configuration
* The relevent OS_MAX limit should be defined
*
* OS_MAX_MODULES is allowed to be zero in which case the
* table is not instantiated.
*/
#if !defined(OS_MAX_MODULES) || (OS_MAX_MODULES <= 0)
#error "osconfig.h must define OS_MAX_MODULES to a valid value"
#endif

Describe the solution you'd like
Fix implementation (if needed), fix comments (if needed)

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC, OSAL code review

@skliper skliper added this to the 6.0.0 milestone Mar 11, 2021
jphickey added a commit to jphickey/osal that referenced this issue Mar 15, 2021
astrogeco added a commit that referenced this issue Mar 22, 2021
Fix #882, make module comment same as other services
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
Fix nasa#882, Returned processor ID to default to unbreak toolchain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants