-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1147, Correct typos in documentation, print statements, and comments #1137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very thorough, thank you! Did you use a spellcheck script?
My only request is that you split commits with one only dealing with documentation typos (.txt and .md files) another commit that addresses "comment" typos and one last commit that addresses actual source code typos (like the print statement for seMinitialize).
Yeah no worries Gerardo - I thought it might be better to split them but wasn't sure. Re. spellcheck script? No - maybe if I knew how to do that I would have haha! |
Haha - re. 'thorough' - yeah. I suppose I thought... if I'm going to do it, may as well do it properly. (although I did leave in a few hundred very minor mistakes like its/it's etc. which are below even my threshold for worth correcting ;-) |
f0e3190
to
db37749
Compare
@astrogeco - The commit has been split into comments/docs/code as requested, and the additional typos that @ArielSAdamsNASA noticed have been incorporated. |
**Combines** nasa/cFE#1915 nasa/osal#1137 nasa/PSP#300 nasa/ci_lab#89 nasa/sample_app#151 nasa/sch_lab#84 nasa/to_lab#101 nasa/sample_lib#65 nasa/elf2cfetbl#82 nasa/tblCRCTool#53 Co-authored-by: Avi <thnkslprpt@users.noreply.github.com>
Fix nasa#1147, Correct typos in documentation, print statements, and comments Part of nasa/cFS#352
**Combines** nasa/cFE#1915 nasa/osal#1137 nasa/PSP#300 nasa/ci_lab#89 nasa/sample_app#151 nasa/sch_lab#84 nasa/to_lab#101 nasa/sample_lib#65 nasa/elf2cfetbl#82 nasa/tblCRCTool#53 Co-authored-by: Avi <thnkslprpt@users.noreply.github.com>
Tested in astrogeco@2a2defb Merged in 2a2defb |
**Combines** nasa/cFE#1915 nasa/osal#1137 nasa/PSP#300 nasa/ci_lab#89 nasa/sample_app#151 nasa/sch_lab#84 nasa/to_lab#101 nasa/sample_lib#65 nasa/elf2cfetbl#82 nasa/tblCRCTool#53 Co-authored-by: Avi <thnkslprpt@users.noreply.github.com>
**Combines** nasa/cFE#1915 nasa/osal#1137 nasa/PSP#300 nasa/ci_lab#89 nasa/sample_app#151 nasa/sch_lab#84 nasa/to_lab#101 nasa/sample_lib#65 nasa/elf2cfetbl#82 nasa/tblCRCTool#53 Co-authored-by: Avi <thnkslprpt@users.noreply.github.com>
Describe the contribution
Fixed various minor text typos in README docs, comments and a few debug/error message strings.
Testing performed
None (non-executable code).
Expected behavior changes
None. Code execution is unchanged/unaffected.
System(s) tested on
n/a
Additional context
n/a
Code contributions
n/a