Fix #864, Refactor duplicate addrlen swtiches into an inline function
#1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * See prototype for argument/return detail | ||
| * | ||
| *-----------------------------------------------------------------*/ | ||
| int32 OS_SocketBind_Impl(const OS_object_token_t *token, const OS_SockAddr_t *Addr) |
Check notice
Code scanning / CodeQL
Long function without assertion
| * | ||
| *-----------------------------------------------------------------*/ | ||
| int32 OS_SocketBind_Impl(const OS_object_token_t *token, const OS_SockAddr_t *Addr) | ||
| static inline socklen_t OS_GetAddrLen(sa_family_t sa_family) |
Check notice
Code scanning / CodeQL
Long function without assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
switchto getaddrlenfrom 3 functions refactored into into a single inline implementationOS_SocketAddrInit_Impl()I can add it.Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
Local tests confirm net coverage unchanged.
Expected behavior changes
No change to behavior.
System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.
Contributor Info
Avi Weiss @thnkslprpt