Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #286, fix cppcheck warning for unit-test #288

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Fix #286, fix cppcheck warning for unit-test #288

merged 1 commit into from
Nov 15, 2019

Conversation

avan989
Copy link
Contributor

@avan989 avan989 commented Nov 12, 2019 •
edited
Loading

Describe the contribution
Resolve cppcheck warning for unit-tests.
Did not compiled unit test.

Testing performed
Steps taken to test the contribution:

  1. cppcheck -force --inline-suppr . 2>cppwarning
  2. Verify warning is gone.

System(s) tested on:

  • Hardware
  • Ubuntu 18.04
  • OSAL 1.4.2a, cppcheck 1.82

Contributor Info
Anh Van, NASA Goddard

Community contributors
You must attach a signed CLA (required for acceptance) or reference one already submitted

skliper
skliper reviewed Nov 12, 2019
View reviewed changes
Copy link
Contributor

@skliper skliper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest for ut_osprintf_offset.c, just move va_end calls after the UT_CheckArgumentOffset call.

@avan989
Copy link
Contributor Author

avan989 commented Nov 13, 2019

updated.

@skliper
Copy link
Contributor

skliper commented Nov 13, 2019

CCB 20191123 - approved for integration candidate

@skliper skliper added the CCB:Approved Indicates code review and approval by community CCB label Nov 13, 2019
@skliper skliper changed the base branch from master to merge-20191115 November 15, 2019 19:24
@skliper skliper merged commit eb8f964 into nasa:merge-20191115 Nov 15, 2019
skliper added a commit that referenced this pull request Nov 15, 2019
@skliper
CCB 20191106: Merge #282, #288
710f8c6 
Fixes #286, fixes #280
Code reviewed and approved at 20191106 CCB
@skliper skliper added this to the 5.1.0 milestone Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skliper skliper skliper approved these changes

Assignees
No one assigned
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Milestone
Bootes
Development

Successfully merging this pull request may close these issues.
2 participants
@avan989 @skliper