Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OS_VxWorks_SigWait test case #322

Merged
merged 1 commit into from
Dec 30, 2019
Merged

Update OS_VxWorks_SigWait test case #322

merged 1 commit into from
Dec 30, 2019

Conversation

jphickey
Copy link
Contributor

Describe the contribution

Fix #321

This is related to the change for #271, where the return value of this function depends on the configured timer interval. The coverage test case for this was not updated in the original change.

Testing performed
Build and execute OSAL coverage tests

Expected behavior changes
Test case now passes, as:

[BEGIN] 03 OS_VxWorks_SigWait
[ PASS] 03.001 coveragetest-ostimer.c:166 - Osapi_Internal_CallSigWaitFunc(0) (1111111) == 1111111 (1111111)
[ PASS] 03.002 coveragetest-ostimer.c:168 - Osapi_Internal_CallSigWaitFunc(0) (2222222) == 2222222 (2222222)
[ PASS] 03.003 coveragetest-ostimer.c:170 - Osapi_Internal_CallSigWaitFunc(0) (2222222) == 2222222 (2222222)
[  END] 03 OS_VxWorks_SigWait   TOTAL::3     PASS::3     FAIL::0      MIR::0      TSF::0      N/A::0

FSW code is not changed.

System(s) tested on:
Ubuntu 18.04 LTS, 64 bit

Contributor Info
Joseph Hickey, Vantage Systems, Inc.

Community contributors
You must attach a signed CLA (required for acceptance) or reference one already submitted

@jphickey
Fix nasa#321: Update OS_VxWorks_SigWait test case
30e53e2 
This is related to the change for nasa#271, where the return value
of this function depends on the configured timer interval.  The
coverage test case for this was not updated in the original change.
@skliper skliper added the CCB:Approved Indicates code review and approval by community CCB label Dec 18, 2019
@skliper skliper added this to the 5.1.0 milestone Dec 18, 2019
@skliper
Copy link
Contributor

skliper commented Dec 18, 2019

CCB 20191218 - Reviewed and approved for IC

@skliper skliper changed the base branch from master to merge-20191230 December 30, 2019 21:39
@skliper skliper merged commit cb259b9 into nasa:merge-20191230 Dec 30, 2019
skliper added a commit that referenced this pull request Dec 30, 2019
@skliper
CCB 20191218: Merge #296 #299 #306 #310 #311 #315 #317 #318 #322 #324
9e3027f 
Fix #295, #298, #305, #307, #308,
    #313, #314, #316, #321, #323
Reviewed and approved at 2019-12-18 CCB
@jphickey jphickey deleted the fix-321-vxworks-sigwait-coverage branch February 13, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skliper skliper skliper approved these changes

Assignees
No one assigned
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Milestone
Bootes
Development

Successfully merging this pull request may close these issues.
2 participants
@jphickey @skliper