Integration Candidate 20200108 #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements a more layered architecture for test code. Rather than having each test provide OS_Application_Startup() directly, now the UT assert library provides OS_Application_Startup() in common code. This also introduces a new function OS_Application_Run() to implement the test routine. This replaces UtTest_Run. The actual test setup is now done by a function called UtTest_Setup(). This allows for better layering where UT-Assert provides the notion of an "OSAL application". This is a step toward simplifying the BSP architecture, eventually combining the normal application and unit test BSP code into a single BSP.
On POSIX, call sigtimedwait() on the selected RT signal as part of the set up for the timebase. This ensures that if the signal is already pending, it will be cleared. This also simplifies the timer callback routine in the UT code, cleaning up some unncessary extra logic.
skliper
added
the
CCB:Approved
|
CCB 20200115 - Reviewed and approved for merge to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Merge #325, #336
Fix #294, fix #335
Testing performed
Expected behavior changes
OS timer test should now always pass
System(s) tested on
Additional context
N/A
Third party code
N/A
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC