Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #259, updated osapi-filesys.c + ut_osfilesys_diskio_tes.ct to use… #387

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Fix #259, updated osapi-filesys.c + ut_osfilesys_diskio_tes.ct to use… #387

merged 1 commit into from
Apr 6, 2020

Conversation

dmknutsen
Copy link
Contributor

Describe the contribution
Fixes #259, Updatese osapi-filesys.c + ut_osfilesys_diskio_test.c to use desired return values.

Testing performed

  1. Ran unit tests

Expected behavior changes
The more descriptive return value (OS_ERR_NAME_NOT_FOUND) will now be returned from the following functions (instead of OS_FS_ERROR):
OS_rmfs
OS_mount
OS_unmount
OS_FS_GetPhysDriveName

System(s) tested on
Oracle VM VirtualBox
OS: ubuntu-19.10
Versions: cFE 6.7.10.0, OSAL 5.0.8.0, PSP 1.4.7.0,

Contributor Info
Dan Knutsen
NASA/Goddard

@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Mar 25, 2020
@skliper skliper added this to the 5.1.0 milestone Mar 25, 2020
@astrogeco
Copy link
Contributor

CCB 2020-04-01 - APPROVED

@astrogeco astrogeco added CCB - 20200401 CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Apr 1, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate April 6, 2020 17:44
@astrogeco astrogeco merged commit e52f37c into nasa:integration-candidate Apr 6, 2020
@astrogeco astrogeco changed the title Fixes #259, updated osapi-filesys.c + ut_osfilesys_diskio_tes.ct to use… Fix #259, updated osapi-filesys.c + ut_osfilesys_diskio_tes.ct to use… Apr 6, 2020
@astrogeco astrogeco mentioned this pull request Apr 9, 2020
Merged
This was referenced Apr 13, 2020
Merged
Merged
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
@skliper
20191106/13: Merge nasa#387 nasa#390 nasa#391 nasa#393 nasa#395 nasa#400
9aedaab 


Fixes nasa#379, Fixes nasa#380, Fixes nasa#383, Fixes nasa#384,
Fixes nasa#385, Fixes nasa#392
Code reviewed and approved at 20191106 and 20191113 CB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skliper skliper skliper approved these changes

Assignees
No one assigned
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Milestone
Bootes
Development

Successfully merging this pull request may close these issues.

Remove unit test backwards compatibility in osapi-filesys functions
3 participants
@dmknutsen @astrogeco @skliper