-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #385, Deprecate interrupt related APIs #396
Fix #385, Deprecate interrupt related APIs #396
Conversation
Note this would benefit from #362 being resolved. Also recommend testing for a vxworks and an rtems build. Also as mentioned needs nasa/cFE#456 resolved, and would benefit from the current integration candidate being merged (and rebase this on master).... |
Removes coverage test code completely Marks OS_Int* API's as deprecated and implementations removed if OSAL_OMIT_DEPRECATED defined
eaab23b
to
8f6f81d
Compare
Rebased on current master |
CCB 2020-04-01 - APPROVED |
@skliper see conflict in merge dialog, I assume I should keep the
|
Hard to tell without context, want me to rebase by branch on integration-candidate? |
It should show you the context if you click resolve conflicts. Up to you though. |
Either include them both or delete them both. Basically one commit deprecates all the interrupt APIs, the next deprecates all the shared memory. They can either be all in the same big ifndef block or two separate. |
Describe the contribution
Removes coverage test code completely. Marks OS_Int* API's as deprecated and implementations
removed if OSAL_OMIT_DEPRECATED defined
Fixes #385
Only changes under review for this request are 3618ae3, the rest of the commits were included to avoid merge conflicts (they were included in other pull requests for review)
Testing performed
Steps taken to test the contribution:
Expected behavior changes
None
System(s) tested on
Additional context
Associated OS_Int tickets become wontfix - #376, #370, #71
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC