Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #261, #312, and #362, OSAL build cleanup (multiple issues) #404

Merged

Commits on Apr 10, 2020

  1. Fix nasa#312, CMake cleanup

    Do not clobber the CMAKE_C_FLAGS value as part of the OSAL build.
    Instead, use target_compile_options and target_include_directories
    as needed to set the compile options for specific targets.
    
    This also creates a separate CMakeLists.txt file for each OS/BSP
    implementation library rather than using aux_source_directory.
    Each implementation-specific build can then set any additional
    options as required for that platform.
    
    Note that any entity needing to compile/link with OSAL should
    now obtain the requisite compile flags and directories by querying
    the INTERFACE_COMPILE_DEFINITIONS and INTERFACE_INCLUDE_DIRECTORIES
    properties on the osal library target.
    jphickey committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    2f24f3f View commit details
    Browse the repository at this point in the history
  2. Fix nasa#261, Consolidate unit test and normal BSP

    Refactor the OSAL BSP code so that a single BSP implementation
    can work for both normal applications as well as unit tests.
    
    This intoduces a new bsp implementation abstraction layer akin
    to the low level OS implementation layer.  This handles dealing
    with bootloader/command line arguments, and debug console
    manipluation.
    jphickey committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    f9b9b85 View commit details
    Browse the repository at this point in the history
  3. Fix nasa#362, integrate coverage with UT build

    Build the full suite of OSAL coverage tests as part of
    the normal build when ENABLE_UNIT_TESTS is true.
    
    This will use the same target OSAL BSP to execute the tests
    as is used for the FSW.
    jphickey committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    befa665 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2020

  1. Configuration menu
    Copy the full SHA
    b05e906 View commit details
    Browse the repository at this point in the history
  2. Update nasa#404, Use loop in Console Write

    This ensures that the return value of the write() call is checked,
    and avoids a potential compiler warning.  There is still no recourse if
    the write call fails, but it can retry if it was short.
    jphickey committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    f59b16b View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2020

  1. Update nasa#404, Add DataLen>0 check in write loop

    Avoids calling write() if length is zero.
    jphickey committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    eeab727 View commit details
    Browse the repository at this point in the history