Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #381, Add OS_TimerAdd functional test #452

Conversation

yammajamma
Copy link
Contributor

Fix #381, Add OS_TimerAdd functional test

Describe the contribution
Added OS_TimerAdd functional test

Testing performed
Steps taken to test the contribution:

  1. Standard build and ran unit tests.

Expected behavior changes

System(s) tested on
cFS Dev Server
OS: Ubuntu 18.04
Versions: OSAL 5.0.11.0

Additional context
Yasir Khan
NASA GSFC

@skliper
Copy link
Contributor

skliper commented May 13, 2020

CCB 20200513 - Approved

@skliper
Copy link
Contributor

skliper commented May 13, 2020

CCB 20200513 - reviewed, needs close look at comments

@skliper skliper added this to the 5.1.0 milestone May 16, 2020
@astrogeco
Copy link
Contributor

astrogeco commented May 19, 2020

@yammajamma any movement on these requests? Once you resolve the change requests feel free to remove the "not ready" label and add the "redy for CCB" label

@astrogeco astrogeco added the CCB:Ignore Incomplete Pull Request with open actions. label May 19, 2020
@yammajamma
Copy link
Contributor Author

@astrogeco I have been busy working on another task, as soon as I am done, I will get these resolved, but that won't be today, unfortunately. There are other updates as well, perhaps we can review them all in the next CCB.

@yammajamma yammajamma force-pushed the fix381-OS_TimerAdd-missing-functional-test branch from ee9b1e2 to 7a644f8 Compare May 28, 2020 16:13
@yammajamma
Copy link
Contributor Author

@jphickey requested changes were made.

I had to force push to update to the newer baseline.

@astrogeco astrogeco removed the CCB:Ignore Incomplete Pull Request with open actions. label May 28, 2020
@astrogeco
Copy link
Contributor

@jphickey are we good with these or do you want to bring it back up to the CCB?

@jphickey
Copy link
Contributor

jphickey commented Jun 2, 2020

@jphickey are we good with these or do you want to bring it back up to the CCB?

I'm fine with it, already marked as approved above.

@astrogeco astrogeco changed the base branch from master to integration-candidate June 2, 2020 18:23
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB IC-20200527 labels Jun 2, 2020
@astrogeco astrogeco merged commit f31171a into nasa:integration-candidate Jun 2, 2020
@yammajamma
Copy link
Contributor Author

@skliper , @jphickey I would like to update a part of this test to be able to use OS_MAX_TIMERS value on top of the hard-coded NUMBER_OF_TIMERS value (just like I have done for timer-test.c in PR #490 ). This will allow the test to be functional even if the OS_MAX_TIMERS value is reconfigured. Since the branch I worked on has already been merged in, should I now create a new branch and make the changes there, and create a PR?

@astrogeco
Copy link
Contributor

@yammajamma yep! Put in a new issue with a high-level design intent and address it in a new branch and PR

jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OS_TimerAdd missing functional test
4 participants