Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #457, provide BSP shutdown handler #465

Merged

Conversation

jphickey
Copy link
Contributor

Describe the contribution
This provides a better method of handling test abort, in a BSP-specific manner.

Fixes #457

Testing performed
Build and execute unit tests on RTEMS platform, and run a test that has a problem causing an abort. (e.g. UtAssert_Abort).
Confirm that in normal (non-batch) mode the system stays alive and allows use of the shell to check the system state. When using batch mode the system still shuts down (as expected).

Expected behavior changes
No impact to behavior on Linux/VxWorks.
For RTEMS, will not shutdown the kernel if test abort occurs.

System(s) tested on
Ubuntu 20.04 (native)
RTEMS 4.11 on pc686 via QEMU

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

astrogeco and others added 2 commits May 13, 2020 11:49
Integration Candidate COMBINED 2020-04-29 and 2020-05-06
This provides a better method of handling test abort,
in a BSP-specific manner.
@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label May 16, 2020
@skliper skliper added this to the 5.1.0 milestone May 16, 2020
@astrogeco
Copy link
Contributor

CCB 20200520 - APPROVED

@skliper skliper added CCB-20200520 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels May 20, 2020
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB IC-20200520 labels May 26, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate May 26, 2020 13:47
@astrogeco astrogeco merged commit f5a7224 into nasa:integration-candidate May 26, 2020
@jphickey jphickey deleted the fix-457-bsp-shutdown-handler branch June 19, 2020 16:13
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
Test CFE_ES_ReloadApp bad AppID, core app, file doesn't exist
Test CFE_ES_GetAppID: NULL AppID pointer
Test CFE_ES_GetAppIDByName: NULL AppID pointer
Test CFE_ES_GetAppIDByName: NULL name pointer
Test CFE_ES_DeleteChildTask: Task inactive/invalid case
Test CFE_ES_RegisterCDS: NULL handle and NULL name
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve ABORT handling in RTEMS unit test
3 participants