Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #459, dynamically create RAM disk devices on RTEMS #466

Merged
merged 2 commits into from
May 26, 2020

Conversation

jphickey
Copy link
Contributor

Describe the contribution
Rather than relying on the BSP to preallocate, the ram disk block devices can be created based on request. This correlates with the way RAM disks are implemented on VxWorks and is
cleaner and more flexible by making it more independent of the BSP.

This allows all the unit tests to work on RTEMS without the needing the BSP to preallocate a ramdisk.

Fixes #459

Testing performed
Build and run all unit tests, and sanity check CFE operation

Expected behavior changes
Unit tests work on RTEMS without BSP preallocating ramdisks

System(s) tested on
RTEMS 4.11 on pc686 via QEMU

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

astrogeco and others added 2 commits May 13, 2020 11:49
Integration Candidate COMBINED 2020-04-29 and 2020-05-06
Rather than relying on the BSP to preallocate, the ram disk
block devices can be created based on request.  This correlates
with the way RAM disks are implemented on VxWorks and is
cleaner and more flexible by making it more independent
of the BSP.
@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label May 16, 2020
@skliper skliper added this to the 5.1.0 milestone May 16, 2020
@astrogeco
Copy link
Contributor

CCB 20200520 - APPROVED

@skliper skliper added CCB-20200520 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels May 20, 2020
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB IC-20200520 labels May 26, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate May 26, 2020 13:47
@astrogeco astrogeco merged commit bc24490 into nasa:integration-candidate May 26, 2020
@ghost
Copy link

ghost commented May 28, 2020

This is great. I was going to suggest something similar with my GTOSat RTEMS 5 merge, but will rebase my changes on this instead.

@jphickey jphickey deleted the fix-459-rtems-ramdisk branch June 19, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update RTEMS implementation to dynamically create RAM disk block devices
3 participants