Fix #450, add external source directory for OS/BSP #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration Candidate COMBINED 2020-04-29 and 2020-05-06
If the "OSAL_EXT_SOURCE_DIR" cache variable is set, this location will be checked first for a BSP/OS implementation layer. This can point to an out-of-tree implementation layer if necessary. However it is discouraged from actually doing this as there is no attempt at API stability at the low level implementation layer.
jphickey
added
the
CCB:Ready
skliper
approved these changes
May 16, 2020
|
CCB 20200520 - APPROVED |
skliper
added
CCB-20200520
and removed
CCB:Ready
astrogeco
added
CCB:Approved
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Test the following cases: - CFE_ES_TaskMain() with a CFE_ES_TaskInit() error - Query tasks command with valid lib ID - Error when sending Build Info event - CFE_ES_GenerateVersionEvents() error when sending mission event - Loop coverage for CFE_ES_FindConfigKeyValue()
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#468, Adding coverage for cfe_es_task.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
If the "OSAL_EXT_SOURCE_DIR" cache variable is set, this location will be checked first for a BSP/OS implementation layer. This can point to an out-of-tree implementation layer if necessary.
Fixes #450
Testing performed
Configure a test project to use a BSP provided in the external source dir, and confirm that it builds correctly and sanity check result (unit tests, CFE runs normally).
Expected behavior changes
No impact to behavior unless user requires a BSP/OS implementation which is not part of the included set.
System(s) tested on
Ubuntu 20.04
Additional context
It is discouraged from actually doing this as there is no attempt at API stability at the low level implementation layer.
The actual location of the implementation layer being used is now also displayed during "prep" so that one can confirm its the correct/expected one.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.